From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47047) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TAh48-0004y1-Ue for qemu-devel@nongnu.org; Sun, 09 Sep 2012 08:56:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TAh48-0000Cs-1W for qemu-devel@nongnu.org; Sun, 09 Sep 2012 08:56:44 -0400 Received: from mail-ie0-f173.google.com ([209.85.223.173]:33313) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TAh47-0000Cm-T3 for qemu-devel@nongnu.org; Sun, 09 Sep 2012 08:56:43 -0400 Received: by iebc10 with SMTP id c10so1598071ieb.4 for ; Sun, 09 Sep 2012 05:56:43 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1347154198-8629-1-git-send-email-jcmvbkbc@gmail.com> <1347154198-8629-7-git-send-email-jcmvbkbc@gmail.com> Date: Sun, 9 Sep 2012 13:56:42 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 6/9] target-xtensa: implement FP0 arithmetic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Filippov Cc: Blue Swirl , qemu-devel@nongnu.org On 9 September 2012 13:25, Max Filippov wrote: > On Sun, Sep 9, 2012 at 2:05 PM, Peter Maydell wrote: >> Given that these are just 'v &= 0x7fffffff' and 'v ^= 0x80000000' >> it seems like it would be better to just generate code for them >> rather than calling out to a helper, though in some ways it does >> break the abstraction layer of the softfloat library. I've been >> toying with the idea of doing this for target-arm. > > I doubt that these opcodes are used often enough to justify such > hack. > >> (we could have gen_float32_abs() and gen_float32_chs() in >> softfloat.h, or would that be a worse layering violation in >> the other direction? I dunno.) > > IMHO this approach is a bit cleaner. Mmm, maybe. I think you can reasonably leave your patch as it is, anyway. -- PMM