From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37160) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eehwf-0001cO-12 for qemu-devel@nongnu.org; Thu, 25 Jan 2018 08:52:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eehwe-0000bN-5t for qemu-devel@nongnu.org; Thu, 25 Jan 2018 08:52:01 -0500 Received: from mail-ot0-x243.google.com ([2607:f8b0:4003:c0f::243]:45451) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eehwd-0000bA-Uz for qemu-devel@nongnu.org; Thu, 25 Jan 2018 08:52:00 -0500 Received: by mail-ot0-x243.google.com with SMTP id r4so6724280oti.12 for ; Thu, 25 Jan 2018 05:51:59 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20180125054648.18747-1-famz@redhat.com> References: <20180125054648.18747-1-famz@redhat.com> From: Peter Maydell Date: Thu, 25 Jan 2018 13:51:38 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [PULL 00/14] Block and docker patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: QEMU Developers On 25 January 2018 at 05:46, Fam Zheng wrote: > The following changes since commit 834a336eb911db8a8ca00e760ee6a85faca19414: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2018-01-24 19:24:26 +0000) > > are available in the Git repository at: > > git://github.com/famz/qemu.git tags/staging-pull-request > > for you to fetch changes up to 6b4c4a84a1c7386df30edb4cb3b846b7ded9c707: > > qapi: Add NVMe driver options to the schema (2018-01-25 13:26:54 +0800) > > ---------------------------------------------------------------- > > Hi Peter, this includes: > > - Paolo's docker fix for fedora image. > - Paolo's coroutine lock API improvements. > - My userspace NVMe driver. > > ---------------------------------------------------------------- Hi -- there are a couple of build failures here: NetBSD/OpenBSD/OSX don't like the change to the .texi file: /root/qemu//docs/qemu-block-drivers.texi:788: `disk_images_nvme' has no Up field (perhaps incorrect sectioning?). /root/qemu//docs/qemu-block-drivers.texi:788: warning: unreferenced node `disk_images_nvme'. and some of the other hosts produce this slightly different error for what is probably the same issue: /home/pm215/qemu/qemu-doc.texi:603: node `disk_images' lacks menu item for `disk_images_nvme' despite being its Up target There are some format string problems on 32-bit hosts: /home/peter.maydell/qemu/util/vfio-helpers.c: In function 'qemu_vfio_init_ramblock': /home/peter.maydell/qemu/util/vfio-helpers.c:406:25: error: format '%ld' expects argument of type 'long int', but argument 4 has type 'ram_addr_t {aka unsigned int}' [-Werror=format=] fprintf(stderr, "qemu_vfio_init_ramblock: failed %p %ld\n", ^ /home/peter.maydell/qemu/util/vfio-helpers.c: In function 'qemu_vfio_dump_mapping': /home/peter.maydell/qemu/util/vfio-helpers.c:443:16: error: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'size_t {aka unsigned int}' [-Werror=format=] printf(" vfio mapping %p %lx to %lx\n", m->host, m->size, m->iova); ^ /home/peter.maydell/qemu/util/vfio-helpers.c:443:16: error: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'uint64_t {aka long long unsigned int}' [-Werror=format=] Finally, the clang build spots what looks like a typo: /home/petmay01/linaro/qemu-for-merges/util/vfio-helpers.c:514:55: error: explicitly assigning value of variable of type 'uint64_t' (aka 'unsigned long') to itself [-Werror,-Wself-assign] IOVAMapping m = {.host = host, .size = size, iova = iova}; ~~~~ ^ ~~~~ ...should be ".iova", I imagine. thanks -- PMM