* Re: [Qemu-devel] [PATCH v2 0/9] target/arm: Rely on id regs instead of features [not found] <20180927211322.16118-1-richard.henderson@linaro.org> @ 2018-10-02 12:30 ` Peter Maydell 2018-10-02 13:42 ` Philippe Mathieu-Daudé 2018-10-02 15:32 ` Richard Henderson 0 siblings, 2 replies; 3+ messages in thread From: Peter Maydell @ 2018-10-02 12:30 UTC (permalink / raw) To: Richard Henderson; +Cc: QEMU Developers On 27 September 2018 at 22:13, Richard Henderson <richard.henderson@linaro.org> wrote: > There are more feature bits that could be converted, but I thought > I should show the work to this point to get feedback. > > This is the "v2" as compared to > http://lists.nongnu.org/archive/html/qemu-devel/2018-09/msg01849.html So having written the code both ways round, which do you think works out nicer? (or at least least-worst :-)) thanks -- PMM ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v2 0/9] target/arm: Rely on id regs instead of features 2018-10-02 12:30 ` [Qemu-devel] [PATCH v2 0/9] target/arm: Rely on id regs instead of features Peter Maydell @ 2018-10-02 13:42 ` Philippe Mathieu-Daudé 2018-10-02 15:32 ` Richard Henderson 1 sibling, 0 replies; 3+ messages in thread From: Philippe Mathieu-Daudé @ 2018-10-02 13:42 UTC (permalink / raw) To: Peter Maydell, Richard Henderson; +Cc: QEMU Developers On 02/10/2018 14:30, Peter Maydell wrote: > On 27 September 2018 at 22:13, Richard Henderson > <richard.henderson@linaro.org> wrote: >> There are more feature bits that could be converted, but I thought >> I should show the work to this point to get feedback. >> >> This is the "v2" as compared to >> http://lists.nongnu.org/archive/html/qemu-devel/2018-09/msg01849.html > > So having written the code both ways round, which do you think > works out nicer? (or at least least-worst :-)) Using the *FEATURE*() and FIELD_DP/EX() macros are a great improvement, the code is more concise, easier to review. I also appreciate the arm_features enum cleaned, using the previous macros on ISAR. I doubt this version works worst, but it definitively looks nicer, thus less bug-prone. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v2 0/9] target/arm: Rely on id regs instead of features 2018-10-02 12:30 ` [Qemu-devel] [PATCH v2 0/9] target/arm: Rely on id regs instead of features Peter Maydell 2018-10-02 13:42 ` Philippe Mathieu-Daudé @ 2018-10-02 15:32 ` Richard Henderson 1 sibling, 0 replies; 3+ messages in thread From: Richard Henderson @ 2018-10-02 15:32 UTC (permalink / raw) To: Peter Maydell; +Cc: QEMU Developers On 10/2/18 7:30 AM, Peter Maydell wrote: > On 27 September 2018 at 22:13, Richard Henderson > <richard.henderson@linaro.org> wrote: >> There are more feature bits that could be converted, but I thought >> I should show the work to this point to get feedback. >> >> This is the "v2" as compared to >> http://lists.nongnu.org/archive/html/qemu-devel/2018-09/msg01849.html > > So having written the code both ways round, which do you think > works out nicer? (or at least least-worst :-)) My preference is for v2. r~ ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-02 15:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180927211322.16118-1-richard.henderson@linaro.org>
2018-10-02 12:30 ` [Qemu-devel] [PATCH v2 0/9] target/arm: Rely on id regs instead of features Peter Maydell
2018-10-02 13:42 ` Philippe Mathieu-Daudé
2018-10-02 15:32 ` Richard Henderson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).