From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47836) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RlVi3-0003JO-EJ for qemu-devel@nongnu.org; Thu, 12 Jan 2012 20:13:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RlVi2-0005oI-FE for qemu-devel@nongnu.org; Thu, 12 Jan 2012 20:13:35 -0500 Received: from mail-qw0-f45.google.com ([209.85.216.45]:55848) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RlVi2-0005oD-98 for qemu-devel@nongnu.org; Thu, 12 Jan 2012 20:13:34 -0500 Received: by qaea17 with SMTP id a17so469850qae.4 for ; Thu, 12 Jan 2012 17:13:33 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <4F0F7110.8090100@suse.de> References: <1326390853-1892-1-git-send-email-aliguori@us.ibm.com> <4F0F4361.10201@codemonkey.ws> <4F0F652E.6010307@us.ibm.com> <4F0F7110.8090100@suse.de> Date: Fri, 13 Jan 2012 01:13:33 +0000 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] build: fix target_phys_addr_t to 64-bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Andreas_F=C3=A4rber?= Cc: Anthony Liguori , qemu-devel@nongnu.org On 12 January 2012 23:47, Andreas F=C3=A4rber wrote: > PRI* should never include % or width specifier or prefix. > > What we should IMO do is: > > #define PRIdPLX PRId64 > #define PRIxPLX PRIx64 > #define PRIXPLX PRIX64 > /* or TARGET_PRI*PHYS or whatever */ > > This can then be used as "... %02" PRIxPLX for shortened output. Yes, I like this -- it's using the PRI* as a way of getting "right format specifier for the type" without imposing the width etc on the user, and it lines up with the standard PRI* macros rather than being an oddity like TARGET_FMT_plx is at the moment. -- PMM