From: Peter Maydell <peter.maydell@linaro.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>,
qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH] virtio-snd: check AUD_register_card return value
Date: Thu, 9 Nov 2023 18:03:15 +0000 [thread overview]
Message-ID: <CAFEAcA9-tvxsoGoRksUSQpV-U=Pwc64CD0R17n-QkEwLA8OegA@mail.gmail.com> (raw)
In-Reply-To: <20231109125334-mutt-send-email-mst@kernel.org>
On Thu, 9 Nov 2023 at 17:53, Michael S. Tsirkin <mst@redhat.com> wrote:
>
> On Thu, Nov 09, 2023 at 04:25:04PM +0000, Peter Maydell wrote:
> > On Thu, 9 Nov 2023 at 16:21, Manos Pitsidianakis
> > <manos.pitsidianakis@linaro.org> wrote:
> > >
> > > AUD_register_card might fail. Even though errp was passed as an
> > > argument, the call's return value was not checked for failure.
> >
> > For whoever picks up this patch: we can add
> > "Fixes Coverity CID 1523899" to the commit message.
>
>
> Better:
>
> Fixes: Coverity CID 1523899
I thought "Fixes:" as a header-line like that was for
the commit hash/subject of the commit the patch is fixing?
thanks
-- PMM
next prev parent reply other threads:[~2023-11-09 18:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 16:20 [PATCH] virtio-snd: check AUD_register_card return value Manos Pitsidianakis
2023-11-09 16:25 ` Peter Maydell
2023-11-09 17:53 ` Michael S. Tsirkin
2023-11-09 18:03 ` Peter Maydell [this message]
2023-11-09 23:23 ` Michael S. Tsirkin
2023-11-10 9:26 ` Manos Pitsidianakis
2023-11-09 17:42 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA9-tvxsoGoRksUSQpV-U=Pwc64CD0R17n-QkEwLA8OegA@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=kraxel@redhat.com \
--cc=manos.pitsidianakis@linaro.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).