From: Peter Maydell <peter.maydell@linaro.org>
To: Sebastian Ott <sebott@redhat.com>
Cc: qemu-devel@nongnu.org, Leif Lindholm <quic_llindhol@quicinc.com>
Subject: Re: [PATCH] hw/arm: fix PMU IRQ registration
Date: Fri, 3 Nov 2023 15:33:24 +0000 [thread overview]
Message-ID: <CAFEAcA90SQL3BdH9teaoLu-YLrcijzKpsDqib6KJjZjhrgEm1Q@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA_w5fM57L81vpByTnOPvdn455xBXtU7UnHFGuJuq-0New@mail.gmail.com>
On Fri, 3 Nov 2023 at 14:27, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Fri, 3 Nov 2023 at 14:14, Sebastian Ott <sebott@redhat.com> wrote:
> >
> > Since commit 9036e917f8 ("{include/}hw/arm: refactor virt PPI logic")
> > PMU IRQ registration fails for arm64 guests:
> >
> > [ 0.563689] hw perfevents: unable to request IRQ14 for ARM PMU counters
> > [ 0.565160] armv8-pmu: probe of pmu failed with error -22
> >
> > That commit re-defined VIRTUAL_PMU_IRQ to be a INTID but missed a case
> > where the PMU IRQ is actually referred by its PPI index. Fix that by using
> > INTID_TO_PPI() in that case.
> >
> > Fixes: 9036e917f8 ("{include/}hw/arm: refactor virt PPI logic")
> > Signed-off-by: Sebastian Ott <sebott@redhat.com>
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1960
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
...and applied to target-arm.next, thanks.
-- PMM
prev parent reply other threads:[~2023-11-03 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 14:14 [PATCH] hw/arm: fix PMU IRQ registration Sebastian Ott
2023-11-03 14:27 ` Peter Maydell
2023-11-03 15:33 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA90SQL3BdH9teaoLu-YLrcijzKpsDqib6KJjZjhrgEm1Q@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quic_llindhol@quicinc.com \
--cc=sebott@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).