From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47866)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YLlEr-0000gO-4H
	for qemu-devel@nongnu.org; Wed, 11 Feb 2015 23:18:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YLlEm-0008Qo-5u
	for qemu-devel@nongnu.org; Wed, 11 Feb 2015 23:18:53 -0500
Received: from mail-pd0-f182.google.com ([209.85.192.182]:36019)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YLlEm-0008Qf-0i
	for qemu-devel@nongnu.org; Wed, 11 Feb 2015 23:18:48 -0500
Received: by pdjp10 with SMTP id p10so9182970pdj.3
	for <qemu-devel@nongnu.org>; Wed, 11 Feb 2015 20:18:47 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <d92eb46865f162caff1ca2f98b4e618608051ff3.1423298325.git.jan.kiszka@web.de>
References: <cover.1423298325.git.jan.kiszka@web.de>
	<d92eb46865f162caff1ca2f98b4e618608051ff3.1423298325.git.jan.kiszka@web.de>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Thu, 12 Feb 2015 04:18:26 +0000
Message-ID: <CAFEAcA90eh1jpzubKMN-mHSeBa+JfeBQBpHn285xPcdKavm8Hg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 1/4] gdbstub: Fix qOffsets packet detection
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Pedro Alves <palves@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Fabien Chouteau <chouteau@adacore.com>, Jan Kiszka <jan.kiszka@siemens.com>

On 7 February 2015 at 08:38, Jan Kiszka <jan.kiszka@web.de> wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> qOffsets has no additional optional parameters. So match the complete
> string to avoid stumbling over possible future commands with identical
> prefix.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  gdbstub.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdbstub.c b/gdbstub.c
> index e4a1a79..cd25d1a 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -1107,7 +1107,7 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf)
>              break;
>          }
>  #ifdef CONFIG_USER_ONLY
> -        else if (strncmp(p, "Offsets", 7) == 0) {
> +        else if (strcmp(p, "Offsets") == 0) {
>              TaskState *ts = s->c_cpu->opaque;
>
>              snprintf(buf, sizeof(buf),

We could write this as
 if (is_query_packet(p, "Offsets", 0))
but straight strcmp() works fine too.

-- PMM