qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
	qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
	"Mahmoud Mandour" <ma.mandourr@gmail.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Alexandre Iooss" <erdnaxe@crans.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH 0/6] build contrib/plugins using meson
Date: Thu, 15 Aug 2024 20:14:35 +0100	[thread overview]
Message-ID: <CAFEAcA91B6BNu=dkYbSOZQzFcspk0NnFQV5VkiWE6CtxZnWg9w@mail.gmail.com> (raw)
In-Reply-To: <CABgObfZ2qiOg3WYerO7nUP4U+726f2=ToBiTdi=Jx18DRNkxhQ@mail.gmail.com>

On Thu, 15 Aug 2024 at 19:38, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On Thu, Aug 15, 2024 at 8:04 PM Pierrick Bouvier
> <pierrick.bouvier@linaro.org> wrote:
> > > One argument from moving contrib/plugins to meson is that the Windows
> > > case depends on libqemu_plugin_api.a which is built with meson(*);
> > > that said, libqemu_plugin_api.a should be installed - which would
> > > justify it being used from an "external" makefile.
> >
> > You need meson to build this lib in the first place, so I guess that
> > 99.9% of the people writing a plugin will have a qemu source tree (with
> > access to plugin headers), and first compile the lib.
>
> Note that the lib is built at configure time, not Make time.  It's not
> a normal library.
>
> > I am not convinced by the scenario where people build this out of tree
> > to be honest, but I may be wrong.
>
> The idea is that people copy the Makefile, and yeah I'm not sure
> either if they do it but it can be useful.

The original theory was that since plugins are supposed to
be independent of QEMU version that we should have the
build system also be independent of QEMU (and perhaps that
plugins might not be in the QEMU source tree at all some day).
That's why they're in contrib/ (though I am not a fan of
contrib/ as an organizational category in the filesystem...)

-- PMM


  reply	other threads:[~2024-08-15 19:15 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-14 23:36 [PATCH 0/6] build contrib/plugins using meson Pierrick Bouvier
2024-08-14 23:36 ` [PATCH 1/6] contrib/plugins/execlog: fix warning Pierrick Bouvier
2024-08-15  8:06   ` Thomas Huth
2024-08-17  6:47   ` Alexandre IOOSS
2024-08-14 23:36 ` [PATCH 2/6] contrib/plugins/cache: fix warning when compiling on 32bits host Pierrick Bouvier
2024-08-15  8:11   ` Thomas Huth
2024-08-15 11:46     ` Alex Bennée
2024-08-15 17:38       ` Pierrick Bouvier
2024-08-16  2:16         ` Pierrick Bouvier
2024-08-16 12:49         ` Alex Bennée
2024-08-15 22:23       ` Richard Henderson
2024-08-16 12:47         ` Alex Bennée
2024-08-16 14:17           ` Peter Maydell
2024-08-16 21:58           ` Richard Henderson
2024-08-14 23:36 ` [PATCH 3/6] contrib/plugins/hwprofile: " Pierrick Bouvier
2024-08-15  8:13   ` Thomas Huth
2024-08-15 12:03     ` Alex Bennée
2024-08-15 17:40       ` Pierrick Bouvier
2024-08-16  4:50         ` Pierrick Bouvier
2024-08-14 23:36 ` [PATCH 4/6] contrib/plugins/hotblocks: " Pierrick Bouvier
2024-08-15  8:14   ` Thomas Huth
2024-08-14 23:36 ` [PATCH 5/6] meson: build contrib/plugins with meson Pierrick Bouvier
2024-08-14 23:36 ` [PATCH 6/6] contrib/plugins: remove Makefile for contrib/plugins Pierrick Bouvier
2024-08-15  6:00 ` [PATCH 0/6] build contrib/plugins using meson Paolo Bonzini
2024-08-15 11:42   ` Alex Bennée
2024-08-15 17:42     ` Pierrick Bouvier
2024-08-15 18:04   ` Pierrick Bouvier
2024-08-15 18:37     ` Paolo Bonzini
2024-08-15 19:14       ` Peter Maydell [this message]
2024-08-16  6:50     ` Philippe Mathieu-Daudé
2024-08-16 18:44       ` Pierrick Bouvier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA91B6BNu=dkYbSOZQzFcspk0NnFQV5VkiWE6CtxZnWg9w@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=erdnaxe@crans.org \
    --cc=ma.mandourr@gmail.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=pierrick.bouvier@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).