From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47430)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1VsGyN-00060R-CV
	for qemu-devel@nongnu.org; Sun, 15 Dec 2013 14:03:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1VsGyI-0000qc-Gg
	for qemu-devel@nongnu.org; Sun, 15 Dec 2013 14:03:27 -0500
Received: from mail-pd0-f174.google.com ([209.85.192.174]:47220)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1VsGyI-0000qS-AU
	for qemu-devel@nongnu.org; Sun, 15 Dec 2013 14:03:22 -0500
Received: by mail-pd0-f174.google.com with SMTP id y13so4392248pdi.5
	for <qemu-devel@nongnu.org>; Sun, 15 Dec 2013 11:03:21 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <52ADFA17.2000109@suse.de>
References: <1368475464-3116-1-git-send-email-green@moxielogic.com>
	<8761qqn496.fsf@moxielogic.com> <52ADFA17.2000109@suse.de>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Sun, 15 Dec 2013 19:03:01 +0000
Message-ID: <CAFEAcA91BoCgAR5ahoFWWWEOzWjwzW0vmv2Ei9NprUwR6T4VKg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] ping.. Re: [PATCH moxie] Fix bug in tlb_fill.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>, Anthony Green <green@moxielogic.com>, QEMU Developers <qemu-devel@nongnu.org>, Max Filippov <jcmvbkbc@gmail.com>, Anthony Liguori <aliguori@amazon.com>, Richard Henderson <rth@twiddle.net>

On 15 December 2013 18:51, Andreas F=C3=A4rber <afaerber@suse.de> wrote:
> Am 15.12.2013 05:10, schrieb Anthony Green:
>> This patch still needs to be applied.  There was some follow-up
>> discussion on this patch back in May, but none of it negates the fact
>> that this patch needs to be applied.
>
> It introduces a tab, please fix.
>
> Apart from that I believe I reported some inconsistencies between
> targets in that function, so "all targets except moxie do it conditional
> to FOO" may be a convincing explanation independent of the bug you were
> discussing that may or may not be otherwise workaroundable.

I dug out the thread where you did that (which turns out to be
private mail and not qemu-devel). In follow up to that RTH and I
agreed that it definitely is a bug and this patch is the correct fix.

> And since this is purely in target-moxie I would suggest to simply send
> a pull as target maintainer once you have someone trustworthy's
> Reviewed-by and it doesn't break `make check`, similar to how it's done
> for OpenRISC.

Yes, this makes sense to me, especially since Anthony has a number
of other moxie patches on list at this point.

thanks
-- PMM