From: Peter Maydell <peter.maydell@linaro.org>
To: "Emilio G. Cota" <cota@braap.org>
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"patches@linaro.org" <patches@linaro.org>,
"Howard Spoelstra" <hsp.cat7@gmail.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] accel/tcg: Consider cluster index in tb_lookup__cpu_state()
Date: Wed, 6 Feb 2019 19:40:35 +0000 [thread overview]
Message-ID: <CAFEAcA93+JnWz9h0tBhM016Qu7afAYs3vkdTWNTLPm-3u-ehsA@mail.gmail.com> (raw)
In-Reply-To: <20190206155547.GA13624@flamenco>
On Wed, 6 Feb 2019 at 15:55, Emilio G. Cota <cota@braap.org> wrote:
>
> On Wed, Feb 06, 2019 at 03:15:26 +0000, Richard Henderson wrote:
> > > Does anybody know why tb_lookup__cpu_state() has that odd
> > > double-underscore in the middle of its name?
> >
> > I'm inclined to think typo... Emilio?
>
> It's not a typo -- it's there to separate "tb lookup" and
> "cpu state" to avoid ambiguity when guessing what
> the function does based on its name.
OK, I wouldn't have guessed that -- my assumption was
"accidentally removed a name component with sed" or
"just a typo", and I didn't assign any semantic meaning
to the double underscore...
thanks
-- PMM
next prev parent reply other threads:[~2019-02-06 19:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 15:18 [Qemu-devel] [PATCH] accel/tcg: Consider cluster index in tb_lookup__cpu_state() Peter Maydell
2019-02-05 16:52 ` Cleber Rosa
2019-02-05 17:09 ` Mark Cave-Ayland
2019-02-05 17:14 ` Howard Spoelstra
2019-02-06 3:15 ` Richard Henderson
2019-02-06 15:55 ` Emilio G. Cota
2019-02-06 19:40 ` Peter Maydell [this message]
2019-02-06 3:48 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA93+JnWz9h0tBhM016Qu7afAYs3vkdTWNTLPm-3u-ehsA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=cota@braap.org \
--cc=crosa@redhat.com \
--cc=hsp.cat7@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).