From: Peter Maydell <peter.maydell@linaro.org>
To: Hao Wu <wuhaotsh@google.com>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
qemu-devel@nongnu.org, "Tyrone Ting" <kfting@nuvoton.com>,
"Fabiano Rosas" <farosas@suse.de>,
"Laurent Vivier" <lvivier@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"open list:Nuvoton NPCM7xx" <qemu-arm@nongnu.org>
Subject: Re: [RFC PATCH] tests/qtest: don't step clock at start of npcm7xx periodic IRQ test
Date: Tue, 21 Jan 2025 09:53:35 +0000 [thread overview]
Message-ID: <CAFEAcA93xPuBTN6LSHLjXGfzar2ZUZsBBxJVzLOPM9_FooS5Sg@mail.gmail.com> (raw)
In-Reply-To: <CAGcCb10gHVZdN6CbUm02w7jTaUUoBH4-VTohmy+yiP1OLWFBxg@mail.gmail.com>
On Mon, 20 Jan 2025 at 23:52, Hao Wu <wuhaotsh@google.com> wrote:
>
> Have you tried that the test can pass with this? If I remember correctly, interrupt won't trigger properly if not advancing the timer
>
> If the test passes it's probably fine to remove that.
This specific clock_step_next() call is done immediately after
resetting the timer device, so there *is* no pending interrupt.
(That's why it's a problem -- it says "step the clock forward
to the next pending timer expiry", and there is no next
pending timer expiry.)
There's another clock_step_next() just after the context
in this patch, and that one is fine, because it's after
the test enables the timer and so there will be a
next pending expiry to step forward to.
thanks
-- PMM
next prev parent reply other threads:[~2025-01-21 9:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250120150049.3611864-1-alex.bennee@linaro.org>
2025-01-20 23:52 ` [RFC PATCH] tests/qtest: don't step clock at start of npcm7xx periodic IRQ test Hao Wu
2025-01-21 9:53 ` Peter Maydell [this message]
2025-01-21 10:19 ` Alex Bennée
2025-01-22 6:35 ` Hao Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA93xPuBTN6LSHLjXGfzar2ZUZsBBxJVzLOPM9_FooS5Sg@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=farosas@suse.de \
--cc=kfting@nuvoton.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=wuhaotsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).