From: Peter Maydell <peter.maydell@linaro.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
Thomas Huth <thuth@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
Qemu Developers <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch
Date: Fri, 8 Jun 2018 17:14:09 +0100 [thread overview]
Message-ID: <CAFEAcA943cBfMbjBJcheTWAL+mWa4vu5uL62LvKXS4agd+ZRMA@mail.gmail.com> (raw)
In-Reply-To: <20180608185714-mutt-send-email-mst@kernel.org>
On 8 June 2018 at 16:59, Michael S. Tsirkin <mst@redhat.com> wrote:
> The expected value tests are a debugging aid. They do not catch bugs and
> aren't designed to. In particular the comparisons do not even run if
> IASL isn't installed.
If they're not actually tests to catch bugs, maybe we shouldn't
be running them in "make check" ?
thanks
-- PMM
next prev parent reply other threads:[~2018-06-08 16:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 22:31 [Qemu-devel] [qemu PATCH 1/5] gitignore: ignore generated qapi job files Ross Zwisler
2018-06-07 22:31 ` [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch Ross Zwisler
2018-06-07 23:09 ` Michael S. Tsirkin
2018-06-08 5:17 ` Thomas Huth
2018-06-08 15:34 ` Ross Zwisler
2018-06-08 15:59 ` Michael S. Tsirkin
2018-06-08 16:14 ` Peter Maydell [this message]
2018-06-08 16:21 ` Michael S. Tsirkin
2018-06-08 16:03 ` Michael S. Tsirkin
2018-06-08 16:16 ` Peter Maydell
2018-06-08 16:24 ` Michael S. Tsirkin
2018-06-08 17:23 ` Thomas Huth
2018-06-08 18:41 ` Michael S. Tsirkin
2018-06-08 19:56 ` Thomas Huth
2018-06-07 22:31 ` [Qemu-devel] [qemu PATCH 3/5] hw/i386: Update SSDT table used by "make check" Ross Zwisler
2018-06-07 23:14 ` Michael S. Tsirkin
2018-06-08 14:24 ` Eric Blake
2018-06-08 16:00 ` Michael S. Tsirkin
2018-06-08 5:39 ` Thomas Huth
2018-06-07 22:31 ` [Qemu-devel] [qemu PATCH 4/5] machine: fix some misspelled words Ross Zwisler
2018-06-08 5:38 ` Thomas Huth
2018-06-08 17:41 ` Ross Zwisler
2018-06-08 18:01 ` Eric Blake
2018-06-07 22:31 ` [Qemu-devel] [qemu PATCH 5/5] nvdimm: make persistence option symbolic Ross Zwisler
2018-06-08 19:34 ` Michael S. Tsirkin
2018-06-08 14:59 ` [Qemu-devel] [qemu PATCH 1/5] gitignore: ignore generated qapi job files Eric Blake
2018-06-08 15:00 ` Eric Blake
2018-06-08 15:36 ` Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA943cBfMbjBJcheTWAL+mWa4vu5uL62LvKXS4agd+ZRMA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=dan.j.williams@intel.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=linux-nvdimm@lists.01.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ross.zwisler@linux.intel.com \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).