qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] docs/system/cpu-hotplug: Update example's socket-id/core-id
Date: Thu, 19 Sep 2024 13:34:54 +0100	[thread overview]
Message-ID: <CAFEAcA94EdUOOk71nv4oFRJXNBM=62FCD9dfwVSWMS-VM_OZtw@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA_Rjiy1so28OVPpL=+++XuU+gSXhn-v_WHMcpc_wa_xMw@mail.gmail.com>

On Tue, 10 Sept 2024 at 10:38, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Tue, 10 Sept 2024 at 10:03, Igor Mammedov <imammedo@redhat.com> wrote:
> >
> > On Mon, 19 Aug 2024 15:43:03 +0100
> > Peter Maydell <peter.maydell@linaro.org> wrote:
> > > @@ -83,34 +83,32 @@ vCPU hotplug
> > >
> > >        (QEMU) query-cpus-fast
> > >        {
> > > -          "execute": "query-cpus-fast",
> > >            "arguments": {}
> > > +          "execute": "query-cpus-fast",
> > >        }
> > >        {
> > >            "return": [
> > >                {
> > > -                  "qom-path": "/machine/unattached/device[0]",
> > > -                  "target": "x86_64",
> > > -                  "thread-id": 11534,
> > >                    "cpu-index": 0,
> > >                    "props": {
> > > -                      "socket-id": 0,
> > >                        "core-id": 0,
> > > +                      "socket-id": 0,
> > >                        "thread-id": 0
> > >                    },
> > > -                  "arch": "x86"
> > > +                  "qom-path": "/machine/unattached/device[0]",
> > > +                  "target": "x86_64",
> > > +                  "thread-id": 28957
> > >                },
> > >                {
> > > -                  "qom-path": "/machine/peripheral/cpu-2",
> > > -                  "target": "x86_64",
> > > -                  "thread-id": 12106,
> > >                    "cpu-index": 1,
> > >                    "props": {
> > > -                      "socket-id": 1,
> > > -                      "core-id": 0,
> > > +                      "core-id": 1,
> > > +                      "socket-id": 0,
> > >                        "thread-id": 0
> > >                    },
> > > -                  "arch": "x86"
> > > +                  "qom-path": "/machine/peripheral/cpu-2",
> > > +                  "target": "x86_64",
> > > +                  "thread-id": 29095
> > >                }
> >
> > beside reordering, which seems fine, this hunk also introduces target change
> > perhaps a separate patch for that?
>
> What target change? It all says "target": "x86_64" both before
> and after.

Hi Igor, would you mind clarifying what you meant here?
I'm happy to respin, but I don't understand what change you're
asking for.

thanks
-- PMM


  reply	other threads:[~2024-09-19 12:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-19 14:43 [PATCH] docs/system/cpu-hotplug: Update example's socket-id/core-id Peter Maydell
2024-09-06 15:13 ` Peter Maydell
2024-09-10  9:03 ` Igor Mammedov
2024-09-10  9:38   ` Peter Maydell
2024-09-19 12:34     ` Peter Maydell [this message]
2024-09-20 10:45       ` Igor Mammedov
2024-10-03 14:54         ` Peter Maydell
2024-10-07 12:04           ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA94EdUOOk71nv4oFRJXNBM=62FCD9dfwVSWMS-VM_OZtw@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=imammedo@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).