From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44653) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwDDX-0005FR-PK for qemu-devel@nongnu.org; Mon, 17 Oct 2016 15:05:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwDDW-0002Uf-TQ for qemu-devel@nongnu.org; Mon, 17 Oct 2016 15:04:59 -0400 Received: from mail-vk0-x22d.google.com ([2607:f8b0:400c:c05::22d]:33023) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bwDDW-0002UU-GA for qemu-devel@nongnu.org; Mon, 17 Oct 2016 15:04:58 -0400 Received: by mail-vk0-x22d.google.com with SMTP id 83so165310440vkd.0 for ; Mon, 17 Oct 2016 12:04:58 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20161017185126.GD12934@work-vm> References: <20161017185126.GD12934@work-vm> From: Peter Maydell Date: Mon, 17 Oct 2016 20:04:37 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] qemu master tests/vmstate prints "Failed to load simple/primitive:b_1" etc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: QEMU Developers On 17 October 2016 at 19:51, Dr. David Alan Gilbert wrote: > * Peter Maydell (peter.maydell@linaro.org) wrote: >> I've just noticed that qemu master running 'make check' prints >> GTESTER tests/test-vmstate >> Failed to load simple/primitive:b_1 >> Failed to load simple/primitive:i64_2 >> Failed to load simple/primitive:i32_1 >> Failed to load simple/primitive:i32_1 >> >> but the test doesn't fail. >> >> Can we either (a) silence this output if it's spurious or (b) have >> it cause the test to fail if it's real (and fix the cause of the >> failure ;-)), please? > > The test (has always) tried loading truncated versions of the migration > stream and made sure that it receives an error from vmstate_load_state. > > However I just added an error so we can see which field fails to load > in a migration where we just used to get a 'migration has failed with -22' > > Is there a way to silence error_report's that's already in use in tests? We have some nasty hacks (like check for 'qtest_enabled()' before calling error_report()) but we don't have anything in the tree today that's a more coherent approach to the "test deliberately provoked this error" problem. thanks -- PMM