[PULL 0/1] Socket next patches

[PULL 0/1] Socket next patches

[Daniel P. Berrangé]

The following changes since commit 44423107e7b5731ef40c5c8632a5bad8b49d0838:

  Merge remote-tracking branch 'remotes/xtensa/tags/20200821-xtensa' into staging (2020-08-24 19:55:23 +0100)

are available in the Git repository at:

  https://github.com/berrange/qemu tags/socket-next-pull-request

for you to fetch changes up to 74a57ddc02c41f8f4bb549cedb107c1086daba58:

  tests: fix a memory in test_socket_unix_abstract_good (2020-08-25 11:49:49 +0100)

----------------------------------------------------------------
Add support for UNIX sockets in the abstract namespace

----------------------------------------------------------------

Li Qiang (1):
  tests: fix a memory in test_socket_unix_abstract_good

 tests/test-util-sockets.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.26.2

[PULL 1/1] tests: fix a memory in test_socket_unix_abstract_good

[Daniel P. Berrangé]

From: Li Qiang <liq3ea@163.com>

After build qemu with '-fsanitize=address' extra-cflags,
'make check' show following leak:

=================================================================
==44580==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 2500 byte(s) in 1 object(s) allocated from:
    #0 0x7f1b5a8b8d28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28)
    #1 0x7f1b5a514b10 in g_malloc0 (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x51b10)
    #2 0xd79ea4e4c0ad31c3  (<unknown module>)

SUMMARY: AddressSanitizer: 2500 byte(s) leaked in 1 allocation(s).

Call 'g_rand_free' in the end of function to avoid this.

Fixes: 4d3a329af59("tests/util-sockets: add abstract unix socket cases")
Signed-off-by: Li Qiang <liq3ea@163.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by:  xiaoqiang zhao <zxq_yx_007@163.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 tests/test-util-sockets.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/test-util-sockets.c b/tests/test-util-sockets.c
index 261dc48c03..af9f5c0c70 100644
--- a/tests/test-util-sockets.c
+++ b/tests/test-util-sockets.c
@@ -313,6 +313,7 @@ static void test_socket_unix_abstract_good(void)
     g_thread_join(serv);
 
     g_free(abstract_sock_name);
+    g_rand_free(r);
 }
 #endif
 
-- 
2.26.2

Re: [PULL 0/1] Socket next patches

[Peter Maydell]

On Tue, 25 Aug 2020 at 11:53, Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> The following changes since commit 44423107e7b5731ef40c5c8632a5bad8b49d0838:
>
>   Merge remote-tracking branch 'remotes/xtensa/tags/20200821-xtensa' into staging (2020-08-24 19:55:23 +0100)
>
> are available in the Git repository at:
>
>   https://github.com/berrange/qemu tags/socket-next-pull-request
>
> for you to fetch changes up to 74a57ddc02c41f8f4bb549cedb107c1086daba58:
>
>   tests: fix a memory in test_socket_unix_abstract_good (2020-08-25 11:49:49 +0100)
>
> ----------------------------------------------------------------
> Add support for UNIX sockets in the abstract namespace
>
> ----------------------------------------------------------------


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/5.2
for any user-visible changes.

-- PMM