From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QmSPc-0001Y7-96 for qemu-devel@nongnu.org; Thu, 28 Jul 2011 11:22:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QmSPb-0000aa-Eb for qemu-devel@nongnu.org; Thu, 28 Jul 2011 11:22:12 -0400 Received: from mail-qy0-f173.google.com ([209.85.216.173]:37950) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QmSPb-0000aT-9m for qemu-devel@nongnu.org; Thu, 28 Jul 2011 11:22:11 -0400 Received: by qyk10 with SMTP id 10so3178299qyk.4 for ; Thu, 28 Jul 2011 08:22:10 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20110728151216.GA18809@amt.cnet> References: <20110728151216.GA18809@amt.cnet> Date: Thu, 28 Jul 2011 16:22:09 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH] net: fix default MAC assignment for hotplugged NICs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcelo Tosatti Cc: Markus Armbruster , qemu-devel@nongnu.org On 28 July 2011 16:12, Marcelo Tosatti wrote: > > The index for assignment of default MAC address is duplicated: > qemu_macaddr_default_if_unset has its own variable and net_init_nic uses > the nic table index. Isn't this already fixed by commit 6eed18568d ? -- PMM