From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34628) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlIU9-00020y-IO for qemu-devel@nongnu.org; Thu, 23 Apr 2015 10:52:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YlIU5-00058Y-JN for qemu-devel@nongnu.org; Thu, 23 Apr 2015 10:52:13 -0400 Received: from mail-ie0-f175.google.com ([209.85.223.175]:36083) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlIU5-00058U-Fa for qemu-devel@nongnu.org; Thu, 23 Apr 2015 10:52:09 -0400 Received: by iebrs15 with SMTP id rs15so62450548ieb.3 for ; Thu, 23 Apr 2015 07:52:08 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1429722561-12651-1-git-send-email-greg.bellows@linaro.org> <1429722561-12651-10-git-send-email-greg.bellows@linaro.org> <20150423024929.GC17116@toto> <20150423112449.GT30629@toto> <20150423113459.GU30629@toto> From: Peter Maydell Date: Thu, 23 Apr 2015 15:51:48 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v2 9/9] target-arm: Add WFx instruction trap support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Bellows Cc: "Edgar E. Iglesias" , =?UTF-8?B?QWxleCBCZW5uw6ll?= , QEMU Developers , Sergey Fedorov On 23 April 2015 at 15:41, Greg Bellows wrote: > Ok it sounds like the primary concern is the performance impact of > constantly trapping wfe to EL2 (in which case HCR must be set to cause > this). Should we still honor EL3 and EL1 trapping ofr wfe? In other words > check if they are the target and allow it if !has_work? We should check what the architecture manual says, but I think that in all the trap-WFE cases it says "traps if the CPU would go into a low power state". QEMU *never* goes into a low power state on WFE, so we never trap. -- PMM