From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56443) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZhrV-0005hv-78 for qemu-devel@nongnu.org; Thu, 11 Jan 2018 13:46:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eZhrU-0007MJ-BQ for qemu-devel@nongnu.org; Thu, 11 Jan 2018 13:46:01 -0500 Received: from mail-ot0-x244.google.com ([2607:f8b0:4003:c0f::244]:35740) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eZhrU-0007Lt-6C for qemu-devel@nongnu.org; Thu, 11 Jan 2018 13:46:00 -0500 Received: by mail-ot0-x244.google.com with SMTP id 53so2957906otj.2 for ; Thu, 11 Jan 2018 10:46:00 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20171218173022.18418-2-richard.henderson@linaro.org> References: <20171218173022.18418-1-richard.henderson@linaro.org> <20171218173022.18418-2-richard.henderson@linaro.org> From: Peter Maydell Date: Thu, 11 Jan 2018 18:45:39 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [PATCH 1/9] target/arm: Mark disas_set_insn_syndrome inline List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: QEMU Developers , qemu-arm On 18 December 2017 at 17:30, Richard Henderson wrote: > If it isn't used when translate.h is included, > we'll get a compiler Werror. > > Signed-off-by: Richard Henderson > --- > target/arm/translate.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/arm/translate.h b/target/arm/translate.h > index cd7313ace7..3f4df91e5e 100644 > --- a/target/arm/translate.h > +++ b/target/arm/translate.h > @@ -108,7 +108,7 @@ static inline int default_exception_el(DisasContext *s) > ? 3 : MAX(1, s->current_el); > } > > -static void disas_set_insn_syndrome(DisasContext *s, uint32_t syn) > +static inline void disas_set_insn_syndrome(DisasContext *s, uint32_t syn) > { > /* We don't need to save all of the syndrome so we mask and shift > * out unneeded bits to help the sleb128 encoder do a better job. > -- > 2.14.3 Reviewed-by: Peter Maydell thanks -- PMM