From: Peter Maydell <peter.maydell@linaro.org>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-devel@nongnu.org, "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Daniel P. Berrange" <berrange@redhat.com>
Subject: Re: [PATCH v2] capstone: use <capstone/capstone.h> instead of <capstone.h>
Date: Tue, 15 Nov 2022 11:02:03 +0000 [thread overview]
Message-ID: <CAFEAcA97jWEQoMnFNwiCSH+K31Ta==nAeNEtUdWK5tECA0VKmQ@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA9z564UNPqaMyuAemp_ctmh6eTZbSi5zR6w46Ndkq4u3Q@mail.gmail.com>
On Tue, 15 Nov 2022 at 11:00, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Tue, 15 Nov 2022 at 09:25, Michael Tokarev <mjt@tls.msk.ru> wrote:
> >
> > 14.11.2022 14:59, Peter Maydell wrote:
> > ..
> > > We can do something like
> > >
> > > config_host_data.set('HAVE_CAPSTONE_CAPSTONE_H',
> > > cc.has_header('capstone/capstone.h', depedencies: [capstone])
> >
> > This doesn't work, because has_header does not have "dependencies"
> > argument.
>
> That's odd, the Meson documentation says it does:
>
> https://mesonbuild.com/Reference-manual_returned_compiler.html#compilerhas_header
>
> "dependencies dep | list[dep]
> Additionally dependencies required for compiling and / or linking."
> and it's not marked with a "since version xxx" tag...
...and we already have a few lines in meson.build that use it:
if cc.has_header('epoxy/egl.h', dependencies: epoxy)
if nettle.found() and not cc.has_header('nettle/xts.h', dependencies: nettle)
-- PMM
next prev parent reply other threads:[~2022-11-15 11:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-13 20:09 [PATCH v2] capstone: use <capstone/capstone.h> instead of <capstone.h> Michael Tokarev
2022-11-14 8:58 ` Daniel P. Berrangé
2022-11-14 9:13 ` Michael Tokarev
2022-11-14 11:14 ` Daniel P. Berrangé
2022-11-14 11:59 ` Peter Maydell
2022-11-14 12:01 ` Daniel P. Berrangé
2022-11-15 9:25 ` Michael Tokarev
2022-11-15 11:00 ` Peter Maydell
2022-11-15 11:02 ` Peter Maydell [this message]
2022-11-15 11:03 ` Michael Tokarev
2022-11-14 13:49 ` Paolo Bonzini
2022-11-15 8:11 ` Daniel P. Berrangé
2022-11-17 14:43 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA97jWEQoMnFNwiCSH+K31Ta==nAeNEtUdWK5tECA0VKmQ@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=berrange@redhat.com \
--cc=f4bug@amsat.org \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).