From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40549) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Te2I4-0000b1-Mp for qemu-devel@nongnu.org; Thu, 29 Nov 2012 06:28:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Te2Hy-0006nb-CL for qemu-devel@nongnu.org; Thu, 29 Nov 2012 06:28:24 -0500 Received: from mail-ia0-f173.google.com ([209.85.210.173]:60501) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Te2Hy-0006nV-7n for qemu-devel@nongnu.org; Thu, 29 Nov 2012 06:28:18 -0500 Received: by mail-ia0-f173.google.com with SMTP id w21so9088367iac.4 for ; Thu, 29 Nov 2012 03:28:17 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1354159971-6720-2-git-send-email-lig.fnst@cn.fujitsu.com> References: <1354159971-6720-1-git-send-email-lig.fnst@cn.fujitsu.com> <1354159971-6720-2-git-send-email-lig.fnst@cn.fujitsu.com> Date: Thu, 29 Nov 2012 11:28:16 +0000 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 2/3] use dr7's bit name for breakpoint List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: liguang Cc: qemu-devel@nongnu.org, imammedo@redhat.com, ehabkost@redhat.com, afaerber@suse.de On 29 November 2012 03:32, liguang wrote: > Signed-off-by: liguang > --- > target-i386/cpu.h | 2 ++ > target-i386/helper.c | 24 +++++++++++------------- > target-i386/misc_helper.c | 6 +++--- > target-i386/seg_helper.c | 6 +++--- > 4 files changed, 19 insertions(+), 19 deletions(-) > > diff --git a/target-i386/cpu.h b/target-i386/cpu.h > index 7f292e6..7ecfe21 100644 > --- a/target-i386/cpu.h > +++ b/target-i386/cpu.h > @@ -561,6 +561,8 @@ > /* dr7 fields */ > /* max breakpoints*/ > #define MAX_BP 4 > +/*enable local breakpoint bit 0,2,4,6*/ > +#define BP_LOCAL 0x55 This needs a better name, to make it clear that it's not just a single enable bit but actually a mask of all the local enable bits. Also needs DR7_ prefix. You've split these changes up between patches inconsistently; either have one patch which adds all the constants and then patches which just use them, or have patches which both add and use the constants, but don't mix the two. I'd recommend that each patch should both add and use a related set of constants, so it's self contained and easy to review. -- PMM