* [Qemu-devel] [PATCH] cryptodev: remove dead code
@ 2018-07-30 8:51 Paolo Bonzini
2018-07-30 9:00 ` Gonglei (Arei)
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Paolo Bonzini @ 2018-07-30 8:51 UTC (permalink / raw)
To: qemu-devel
Reported by Coverity as CID 1390600.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
backends/cryptodev-vhost-user.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/backends/cryptodev-vhost-user.c b/backends/cryptodev-vhost-user.c
index d52daccfcd..d539f14d59 100644
--- a/backends/cryptodev-vhost-user.c
+++ b/backends/cryptodev-vhost-user.c
@@ -157,7 +157,6 @@ static void cryptodev_vhost_user_event(void *opaque, int event)
{
CryptoDevBackendVhostUser *s = opaque;
CryptoDevBackend *b = CRYPTODEV_BACKEND(s);
- Error *err = NULL;
int queues = b->conf.peers.queues;
assert(queues < MAX_CRYPTO_QUEUE_NUM);
@@ -174,10 +173,6 @@ static void cryptodev_vhost_user_event(void *opaque, int event)
cryptodev_vhost_user_stop(queues, s);
break;
}
-
- if (err) {
- error_report_err(err);
- }
}
static void cryptodev_vhost_user_init(
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] cryptodev: remove dead code
2018-07-30 8:51 [Qemu-devel] [PATCH] cryptodev: remove dead code Paolo Bonzini
@ 2018-07-30 9:00 ` Gonglei (Arei)
2018-07-30 10:49 ` Peter Maydell
2018-07-30 11:50 ` Zhoujian (jay)
2 siblings, 0 replies; 6+ messages in thread
From: Gonglei (Arei) @ 2018-07-30 9:00 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel@nongnu.org
> -----Original Message-----
> From: Qemu-devel
> [mailto:qemu-devel-bounces+arei.gonglei=huawei.com@nongnu.org] On
> Behalf Of Paolo Bonzini
> Sent: Monday, July 30, 2018 4:51 PM
> To: qemu-devel@nongnu.org
> Subject: [Qemu-devel] [PATCH] cryptodev: remove dead code
>
> Reported by Coverity as CID 1390600.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> backends/cryptodev-vhost-user.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/backends/cryptodev-vhost-user.c b/backends/cryptodev-vhost-user.c
> index d52daccfcd..d539f14d59 100644
> --- a/backends/cryptodev-vhost-user.c
> +++ b/backends/cryptodev-vhost-user.c
> @@ -157,7 +157,6 @@ static void cryptodev_vhost_user_event(void *opaque,
> int event)
> {
> CryptoDevBackendVhostUser *s = opaque;
> CryptoDevBackend *b = CRYPTODEV_BACKEND(s);
> - Error *err = NULL;
> int queues = b->conf.peers.queues;
>
> assert(queues < MAX_CRYPTO_QUEUE_NUM);
> @@ -174,10 +173,6 @@ static void cryptodev_vhost_user_event(void
> *opaque, int event)
> cryptodev_vhost_user_stop(queues, s);
> break;
> }
> -
> - if (err) {
> - error_report_err(err);
> - }
> }
>
> static void cryptodev_vhost_user_init(
> --
> 2.17.1
>
Reviewed-by: Gonglei <arei.gonglei@huawei.com>
Thanks,
-Gonglei
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] cryptodev: remove dead code
2018-07-30 8:51 [Qemu-devel] [PATCH] cryptodev: remove dead code Paolo Bonzini
2018-07-30 9:00 ` Gonglei (Arei)
@ 2018-07-30 10:49 ` Peter Maydell
2018-07-30 11:31 ` Gonglei (Arei)
2018-07-30 11:50 ` Zhoujian (jay)
2 siblings, 1 reply; 6+ messages in thread
From: Peter Maydell @ 2018-07-30 10:49 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: QEMU Developers, Gonglei (Arei)
On 30 July 2018 at 09:51, Paolo Bonzini <pbonzini@redhat.com> wrote:
> Reported by Coverity as CID 1390600.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
This already has a reviewed patch on-list for this from
back in April:
https://patchwork.ozlabs.org/patch/906041/
so I think we should just apply that.
thanks
-- PMM
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] cryptodev: remove dead code
2018-07-30 10:49 ` Peter Maydell
@ 2018-07-30 11:31 ` Gonglei (Arei)
0 siblings, 0 replies; 6+ messages in thread
From: Gonglei (Arei) @ 2018-07-30 11:31 UTC (permalink / raw)
To: Peter Maydell, Paolo Bonzini; +Cc: QEMU Developers
> -----Original Message-----
> From: Peter Maydell [mailto:peter.maydell@linaro.org]
> Sent: Monday, July 30, 2018 6:49 PM
> To: Paolo Bonzini <pbonzini@redhat.com>
> Cc: QEMU Developers <qemu-devel@nongnu.org>; Gonglei (Arei)
> <arei.gonglei@huawei.com>
> Subject: Re: [Qemu-devel] [PATCH] cryptodev: remove dead code
>
> On 30 July 2018 at 09:51, Paolo Bonzini <pbonzini@redhat.com> wrote:
> > Reported by Coverity as CID 1390600.
> >
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > ---
>
> This already has a reviewed patch on-list for this from
> back in April:
>
> https://patchwork.ozlabs.org/patch/906041/
>
> so I think we should just apply that.
>
Oh, yes. Would you pick it up directly? Or by qemu-trivial?
Thanks,
-Gonglei
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] cryptodev: remove dead code
2018-07-30 8:51 [Qemu-devel] [PATCH] cryptodev: remove dead code Paolo Bonzini
2018-07-30 9:00 ` Gonglei (Arei)
2018-07-30 10:49 ` Peter Maydell
@ 2018-07-30 11:50 ` Zhoujian (jay)
2018-07-30 11:56 ` Paolo Bonzini
2 siblings, 1 reply; 6+ messages in thread
From: Zhoujian (jay) @ 2018-07-30 11:50 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel@nongnu.org; +Cc: Gonglei (Arei)
Hi Paolo,
I've posted a patch before, pls see
https://lists.gnu.org/archive/html/qemu-devel/2018-04/msg05215.html
which reviewed by Stefan
https://lists.gnu.org/archive/html/qemu-devel/2018-05/msg01549.html
It seems that it hasn't been merged. Could you pick it up pls?
Regards,
Jay
> -----Original Message-----
> From: Qemu-devel [mailto:qemu-devel-
> bounces+jianjay.zhou=huawei.com@nongnu.org] On Behalf Of Paolo Bonzini
> Sent: Monday, July 30, 2018 4:51 PM
> To: qemu-devel@nongnu.org
> Subject: [Qemu-devel] [PATCH] cryptodev: remove dead code
>
> Reported by Coverity as CID 1390600.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> backends/cryptodev-vhost-user.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/backends/cryptodev-vhost-user.c b/backends/cryptodev-vhost-
> user.c index d52daccfcd..d539f14d59 100644
> --- a/backends/cryptodev-vhost-user.c
> +++ b/backends/cryptodev-vhost-user.c
> @@ -157,7 +157,6 @@ static void cryptodev_vhost_user_event(void *opaque, int
> event) {
> CryptoDevBackendVhostUser *s = opaque;
> CryptoDevBackend *b = CRYPTODEV_BACKEND(s);
> - Error *err = NULL;
> int queues = b->conf.peers.queues;
>
> assert(queues < MAX_CRYPTO_QUEUE_NUM); @@ -174,10 +173,6 @@ static void
> cryptodev_vhost_user_event(void *opaque, int event)
> cryptodev_vhost_user_stop(queues, s);
> break;
> }
> -
> - if (err) {
> - error_report_err(err);
> - }
> }
>
> static void cryptodev_vhost_user_init(
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] cryptodev: remove dead code
2018-07-30 11:50 ` Zhoujian (jay)
@ 2018-07-30 11:56 ` Paolo Bonzini
0 siblings, 0 replies; 6+ messages in thread
From: Paolo Bonzini @ 2018-07-30 11:56 UTC (permalink / raw)
To: Zhoujian (jay), qemu-devel@nongnu.org; +Cc: Gonglei (Arei)
On 30/07/2018 13:50, Zhoujian (jay) wrote:
> Hi Paolo,
>
> I've posted a patch before, pls see
> https://lists.gnu.org/archive/html/qemu-devel/2018-04/msg05215.html
>
> which reviewed by Stefan
> https://lists.gnu.org/archive/html/qemu-devel/2018-05/msg01549.html
>
> It seems that it hasn't been merged. Could you pick it up pls?
Yes, I will.
Paolo
> Regards,
> Jay
>
>> -----Original Message-----
>> From: Qemu-devel [mailto:qemu-devel-
>> bounces+jianjay.zhou=huawei.com@nongnu.org] On Behalf Of Paolo Bonzini
>> Sent: Monday, July 30, 2018 4:51 PM
>> To: qemu-devel@nongnu.org
>> Subject: [Qemu-devel] [PATCH] cryptodev: remove dead code
>>
>> Reported by Coverity as CID 1390600.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>> backends/cryptodev-vhost-user.c | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/backends/cryptodev-vhost-user.c b/backends/cryptodev-vhost-
>> user.c index d52daccfcd..d539f14d59 100644
>> --- a/backends/cryptodev-vhost-user.c
>> +++ b/backends/cryptodev-vhost-user.c
>> @@ -157,7 +157,6 @@ static void cryptodev_vhost_user_event(void *opaque, int
>> event) {
>> CryptoDevBackendVhostUser *s = opaque;
>> CryptoDevBackend *b = CRYPTODEV_BACKEND(s);
>> - Error *err = NULL;
>> int queues = b->conf.peers.queues;
>>
>> assert(queues < MAX_CRYPTO_QUEUE_NUM); @@ -174,10 +173,6 @@ static void
>> cryptodev_vhost_user_event(void *opaque, int event)
>> cryptodev_vhost_user_stop(queues, s);
>> break;
>> }
>> -
>> - if (err) {
>> - error_report_err(err);
>> - }
>> }
>>
>> static void cryptodev_vhost_user_init(
>> --
>> 2.17.1
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-07-30 11:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-30 8:51 [Qemu-devel] [PATCH] cryptodev: remove dead code Paolo Bonzini
2018-07-30 9:00 ` Gonglei (Arei)
2018-07-30 10:49 ` Peter Maydell
2018-07-30 11:31 ` Gonglei (Arei)
2018-07-30 11:50 ` Zhoujian (jay)
2018-07-30 11:56 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).