From: Peter Maydell <peter.maydell@linaro.org>
To: Hu Tao <hutao@cn.fujitsu.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] configure: replace \n with space in optarg
Date: Mon, 4 Aug 2014 09:50:20 +0100 [thread overview]
Message-ID: <CAFEAcA98-yYdWyOQt7cp3Hx+a5bW-dbqD+BW_zUo=d9-WbVFbA@mail.gmail.com> (raw)
In-Reply-To: <1407136375-19688-1-git-send-email-hutao@cn.fujitsu.com>
On 4 August 2014 08:12, Hu Tao <hutao@cn.fujitsu.com> wrote:
> When optarg happens to contain \n like:
>
> ../configure --target-list='i386-softmmu
> x86_64-softmmu'
>
> make will fail with message:
>
> config-host.mak:45: *** missing separator. Stop.
Why would you put newlines in the option string? This is
likely to break for many configure arguments, not just this
one...
I'm a bit dubious about taking this change unless you can
point to existing practice (eg do autoconf configure scripts
clean up whitespace like this?)
thanks
-- PMM
next prev parent reply other threads:[~2014-08-04 8:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 7:12 [Qemu-devel] [PATCH] configure: replace \n with space in optarg Hu Tao
2014-08-04 8:50 ` Peter Maydell [this message]
2014-08-04 9:29 ` Hu Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA98-yYdWyOQt7cp3Hx+a5bW-dbqD+BW_zUo=d9-WbVFbA@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=hutao@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).