From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44427) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEDyh-0005It-5W for qemu-devel@nongnu.org; Mon, 04 Aug 2014 04:50:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XEDyc-0005Tq-C2 for qemu-devel@nongnu.org; Mon, 04 Aug 2014 04:50:47 -0400 Received: from mail-lb0-f172.google.com ([209.85.217.172]:54183) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEDyb-0005Te-Nf for qemu-devel@nongnu.org; Mon, 04 Aug 2014 04:50:41 -0400 Received: by mail-lb0-f172.google.com with SMTP id z11so5084052lbi.31 for ; Mon, 04 Aug 2014 01:50:40 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1407136375-19688-1-git-send-email-hutao@cn.fujitsu.com> References: <1407136375-19688-1-git-send-email-hutao@cn.fujitsu.com> From: Peter Maydell Date: Mon, 4 Aug 2014 09:50:20 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH] configure: replace \n with space in optarg List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hu Tao Cc: QEMU Developers On 4 August 2014 08:12, Hu Tao wrote: > When optarg happens to contain \n like: > > ../configure --target-list='i386-softmmu > x86_64-softmmu' > > make will fail with message: > > config-host.mak:45: *** missing separator. Stop. Why would you put newlines in the option string? This is likely to break for many configure arguments, not just this one... I'm a bit dubious about taking this change unless you can point to existing practice (eg do autoconf configure scripts clean up whitespace like this?) thanks -- PMM