From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37648) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bn6Qr-00066H-UR for qemu-devel@nongnu.org; Thu, 22 Sep 2016 12:01:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bn6Qq-0001ia-6y for qemu-devel@nongnu.org; Thu, 22 Sep 2016 12:01:04 -0400 Received: from mail-ua0-x232.google.com ([2607:f8b0:400c:c08::232]:36459) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bn6Qq-0001iO-1i for qemu-devel@nongnu.org; Thu, 22 Sep 2016 12:01:04 -0400 Received: by mail-ua0-x232.google.com with SMTP id 15so3477203uai.3 for ; Thu, 22 Sep 2016 09:01:03 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20160922155339.GI2085@work-vm> References: <1472035246-12483-1-git-send-email-dgilbert@redhat.com> <1472035246-12483-5-git-send-email-dgilbert@redhat.com> <20160922155339.GI2085@work-vm> From: Peter Maydell Date: Thu, 22 Sep 2016 17:00:42 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v2 4/5] vmstateify tsc2005 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: QEMU Developers , =?UTF-8?Q?Herv=C3=A9_Poussineau?= , Amit Shah , Juan Quintela On 22 September 2016 at 16:53, Dr. David Alan Gilbert wrote: > * Peter Maydell (peter.maydell@linaro.org) wrote: >> These changes mean the code is now doing bitwise-logic on >> bool variables, for instance: >> s->busy &= s->enabled; > >> We also assign '0' and '1' to them rather than 'true' and 'false'. > > Yes, I went through and as far as I can tell they're always > used as booleans already. Yeah, but using bitwise ops on booleans is the kind of thing that prompts compilers and static analysers and linters to complain, so we should fix those expressions if we're changing the type. thanks -- PMM