From: Peter Maydell <peter.maydell@linaro.org>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: fam@euphon.net, pbonzini@redhat.com, Laurent@vivier.eu,
qemu-devel@nongnu.org
Subject: Re: [PATCH v2 03/10] macfb: increase number of registers saved in MacfbState
Date: Thu, 3 Mar 2022 15:25:30 +0000 [thread overview]
Message-ID: <CAFEAcA98y92fVEyvQTUnOYDLtszS40eX9NAnULHugRMW+gPFdQ@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA8-_khhe0999QB=wsUi=HEcPa6G3C7p_P63UibkF6FNUA@mail.gmail.com>
On Thu, 3 Mar 2022 at 15:25, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Wed, 2 Mar 2022 at 21:31, Mark Cave-Ayland
> <mark.cave-ayland@ilande.co.uk> wrote:
> >
> > The MacOS toolbox ROM accesses a number of addresses between 0x0 and 0x200 during
> > initialisation and resolution changes. Whilst the function of many of these
> > registers is unknown, it is worth the minimal cost of saving these extra values as
> > part of migration to help future-proof the migration stream for the q800 machine
> > as it starts to stabilise.
> >
> > Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> You should either bump the vmstate_macfb version numbers here,
> or at least note in the commit message that although it's a
> migration break we know nobody's migrating this device because
> of the bug we just fixed in the previous commit.
...where by "previous" I mean patch 1.
-- PMM
next prev parent reply other threads:[~2022-03-03 15:52 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 21:27 [PATCH v2 00/10] q800: migration fixes Mark Cave-Ayland
2022-03-02 21:27 ` [PATCH v2 01/10] macfb: add VMStateDescription for MacfbNubusState and MacfbSysBusState Mark Cave-Ayland
2022-03-03 15:22 ` Peter Maydell
2022-03-04 10:19 ` Laurent Vivier
2022-03-02 21:27 ` [PATCH v2 02/10] macfb: don't use special irq_state and irq_mask variables in MacfbState Mark Cave-Ayland
2022-03-04 10:22 ` Laurent Vivier
2022-03-02 21:27 ` [PATCH v2 03/10] macfb: increase number of registers saved " Mark Cave-Ayland
2022-03-03 15:25 ` Peter Maydell
2022-03-03 15:25 ` Peter Maydell [this message]
2022-03-03 17:44 ` Mark Cave-Ayland
2022-03-03 18:40 ` Peter Maydell
2022-03-04 10:24 ` Laurent Vivier
2022-03-02 21:27 ` [PATCH v2 04/10] macfb: add VMStateDescription fields for display type and VBL timer Mark Cave-Ayland
2022-03-03 15:26 ` Peter Maydell
2022-03-03 17:45 ` Mark Cave-Ayland
2022-03-04 10:27 ` Laurent Vivier
2022-03-02 21:27 ` [PATCH v2 05/10] macfb: set initial value of mode control registers in macfb_common_realize() Mark Cave-Ayland
2022-03-03 15:28 ` Peter Maydell
2022-03-04 10:27 ` Laurent Vivier
2022-03-02 21:27 ` [PATCH v2 06/10] esp: introduce esp_set_pdma_cb() function Mark Cave-Ayland
2022-03-04 10:28 ` Laurent Vivier
2022-03-02 21:27 ` [PATCH v2 07/10] esp: introduce esp_pdma_cb() function Mark Cave-Ayland
2022-03-04 10:29 ` Laurent Vivier
2022-03-02 21:27 ` [PATCH v2 08/10] esp: convert ESPState pdma_cb from a function pointer to an integer Mark Cave-Ayland
2022-03-04 10:30 ` Laurent Vivier
2022-03-02 21:27 ` [PATCH v2 09/10] esp: include the current PDMA callback in the migration stream Mark Cave-Ayland
2022-03-03 15:40 ` Peter Maydell
2022-03-03 17:50 ` Mark Cave-Ayland
2022-03-04 10:31 ` Laurent Vivier
2022-03-02 21:27 ` [PATCH v2 10/10] esp: recreate ESPState current_req after migration Mark Cave-Ayland
2022-03-04 10:33 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA98y92fVEyvQTUnOYDLtszS40eX9NAnULHugRMW+gPFdQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=Laurent@vivier.eu \
--cc=fam@euphon.net \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).