Re: [Qemu-devel] [PATCH 0/2] qtest: don't leak pid files and UNIX domain sockets

[Peter Maydell <peter.maydell@linaro.org>]

On 3 February 2014 11:10, Andreas Färber <afaerber@suse.de> wrote:
> As an explanation, the temporary files contain the PID. When they remain
> behind due to test failure *and* the PID wraps around and file names
> thus happen to match, the error was triggered, and thereby not on each
> run but seemingly "sometimes".

Yeah, that's what it looks like to me too.

> I am not 100% familiar with the unlinking and code ordering here, but it
> had looked sane to me back when I looked at it, I just didn't feel
> confident enough for a Reviewed-by. I could give it a spin and add a
> Tested-by if that reassures PMM.

I'm happy the code is good, I'm just being lazy about directly
applying patches to master, especially since Anthony's patches
db is currently stalled and not updating :-) (I guess I need to
deal with that some time, though, since we don't have a mechanism
for handling patches that fall through the cracks between
subsystems beyond "somebody with commit access applies them"...)

thanks
-- PMM