From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34351) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAHeF-0005C4-NC for qemu-devel@nongnu.org; Mon, 03 Feb 2014 06:25:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WAHe9-0005sP-Fs for qemu-devel@nongnu.org; Mon, 03 Feb 2014 06:25:07 -0500 Received: from mail-la0-f54.google.com ([209.85.215.54]:51061) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAHe9-0005s7-9v for qemu-devel@nongnu.org; Mon, 03 Feb 2014 06:25:01 -0500 Received: by mail-la0-f54.google.com with SMTP id y1so5399458lam.27 for ; Mon, 03 Feb 2014 03:25:00 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <52EF7909.4060601@suse.de> References: <1385031835-4472-1-git-send-email-stefanha@redhat.com> <20140203095448.GB11167@stefanha-thinkpad.redhat.com> <52EF7909.4060601@suse.de> From: Peter Maydell Date: Mon, 3 Feb 2014 11:24:40 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/2] qtest: don't leak pid files and UNIX domain sockets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Andreas_F=C3=A4rber?= Cc: QEMU Developers , Stefan Hajnoczi , Gerd Hoffmann On 3 February 2014 11:10, Andreas F=C3=A4rber wrote: > As an explanation, the temporary files contain the PID. When they remain > behind due to test failure *and* the PID wraps around and file names > thus happen to match, the error was triggered, and thereby not on each > run but seemingly "sometimes". Yeah, that's what it looks like to me too. > I am not 100% familiar with the unlinking and code ordering here, but it > had looked sane to me back when I looked at it, I just didn't feel > confident enough for a Reviewed-by. I could give it a spin and add a > Tested-by if that reassures PMM. I'm happy the code is good, I'm just being lazy about directly applying patches to master, especially since Anthony's patches db is currently stalled and not updating :-) (I guess I need to deal with that some time, though, since we don't have a mechanism for handling patches that fall through the cracks between subsystems beyond "somebody with commit access applies them"...) thanks -- PMM