From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38647)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1aRLKO-0001C1-Bw
	for qemu-devel@nongnu.org; Thu, 04 Feb 2016 09:56:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1aRLKN-0001Hd-Do
	for qemu-devel@nongnu.org; Thu, 04 Feb 2016 09:56:12 -0500
Received: from mail-vk0-x234.google.com ([2607:f8b0:400c:c05::234]:36206)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1aRLKN-0001HZ-8J
	for qemu-devel@nongnu.org; Thu, 04 Feb 2016 09:56:11 -0500
Received: by mail-vk0-x234.google.com with SMTP id n1so37676412vkb.3
	for <qemu-devel@nongnu.org>; Thu, 04 Feb 2016 06:56:11 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <145459675563.11777.5257429454748921678.stgit@localhost>
References: <145459675563.11777.5257429454748921678.stgit@localhost>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Thu, 4 Feb 2016 14:55:51 +0000
Message-ID: <CAFEAcA99Cc_9Hnn5W7kw3g4jCxuQmpSQA-Jpiyo2DggUHnKUmw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH ] [trivial] qapi: Build-depend on all json
	files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Llu=C3=ADs_Vilanova?= <vilanova@ac.upc.edu>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On 4 February 2016 at 14:39, Llu=C3=ADs Vilanova <vilanova@ac.upc.edu> wrot=
e:
> Dynamically detects the files used to generate QAPI code, thus ensuring
> it's never out of sync with the sources.
>
> Signed-off-by: Llu=C3=ADs Vilanova <vilanova@ac.upc.edu>
> ---
>  Makefile |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index d0de2d4..627f772 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -269,10 +269,8 @@ $(SRC_PATH)/qga/qapi-schema.json $(SRC_PATH)/scripts=
/qapi-commands.py $(qapi-py)
>                 $(gen-out-type) -o qga/qapi-generated -p "qga-" $<, \
>                 "  GEN   $@")
>
> -qapi-modules =3D $(SRC_PATH)/qapi-schema.json $(SRC_PATH)/qapi/common.js=
on \
> -               $(SRC_PATH)/qapi/block.json $(SRC_PATH)/qapi/block-core.j=
son \
> -               $(SRC_PATH)/qapi/event.json $(SRC_PATH)/qapi/introspect.j=
son \
> -               $(SRC_PATH)/qapi/crypto.json
> +qapi-modules =3D $(SRC_PATH)/qapi-schema.json
> +qapi-modules +=3D $(shell find $(SRC_PATH)/qapi -name "*.json")

All the .json files are in the same directory, so I don't think we should
need to use find here. Does

qapi-modules +=3D $(wildcard $(SRC_PATH)/qapi/*.json))

work ?

thanks
-- PMM