qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Fam Zheng <famz@redhat.com>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] configure: Replace which(1) with "command -v"
Date: Wed, 19 Nov 2014 08:18:58 +0000	[thread overview]
Message-ID: <CAFEAcA99PmxgB9bD5KSprFACwSKWAbCW4ec1m1ohah_dxOhvNQ@mail.gmail.com> (raw)
In-Reply-To: <1416381197-12191-1-git-send-email-famz@redhat.com>

On 19 November 2014 07:13, Fam Zheng <famz@redhat.com> wrote:
> Because which(1) is not always installed, whereas "command -v" is
> the more native way to check for a command.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 47048f0..986a13d 100755
> --- a/configure
> +++ b/configure
> @@ -2727,7 +2727,7 @@ fi
>  if test "$modules" = yes; then
>      shacmd_probe="sha1sum sha1 shasum"
>      for c in $shacmd_probe; do
> -        if which $c >/dev/null 2>&1; then
> +        if command -v $c >/dev/null 2>&1; then
>              shacmd="$c"
>              break
>          fi

Configure already provides the shell function "has"
for checking for existence of a command -- can we just
use that?

thanks
-- PMM

      reply	other threads:[~2014-11-19  8:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-19  7:13 [Qemu-devel] [PATCH] configure: Replace which(1) with "command -v" Fam Zheng
2014-11-19  8:18 ` Peter Maydell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA99PmxgB9bD5KSprFACwSKWAbCW4ec1m1ohah_dxOhvNQ@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=famz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).