From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41352) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvqZI-0007DJ-QN for qemu-devel@nongnu.org; Mon, 09 Nov 2015 12:49:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZvqZH-00017L-Pa for qemu-devel@nongnu.org; Mon, 09 Nov 2015 12:49:24 -0500 Received: from mail-yk0-x22b.google.com ([2607:f8b0:4002:c07::22b]:35374) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvqZH-00017F-JH for qemu-devel@nongnu.org; Mon, 09 Nov 2015 12:49:23 -0500 Received: by ykek133 with SMTP id k133so277953497yke.2 for ; Mon, 09 Nov 2015 09:49:23 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20151109174025.GC9020@work-vm> References: <1447090141-29074-1-git-send-email-quintela@redhat.com> <20151109174025.GC9020@work-vm> From: Peter Maydell Date: Mon, 9 Nov 2015 17:49:03 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PULL 00/57] Migration pull List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: Amit Shah , QEMU Developers , Juan Quintela On 9 November 2015 at 17:40, Dr. David Alan Gilbert wrote: > * Peter Maydell (peter.maydell@linaro.org) wrote: >> 57 patches three days before hard freeze? Are you *really* sure about this? > > Well: > a) It's been posted and tested for a long time now; most things seem happy. > b) It's been posted and reviewed multiple times, the changes since the > previous version are purely cleanups from previous review and one > fix. > c) We've been feeding some smaller parts in, individually, but a lot > of the changes are only used by later parts of the code base, and > people don't like changes going in that aren't used yet. > d) I'm here for those 3 days and after to fix it if it explodes. I'm putting it through the merge process, but I really don't like huge pulls hitting the tree very late in softfreeze. The idea of softfreeze is supposed to be that we start out with a lot of churn and gently drop down towards "no changes except bugfixes" as we hit the hardfreeze date. Big changesets are more likely to be destabilizing, and destabilizing changes are worse the later in the freeze process they hit. Also, by dropping a big pullrequest late you are significantly increasing your risk that compile failures and other "only noticed in the merge process" problems will take long enough to fix that you fail to get the thing in before the hardfreeze deadline. Any pull request of 50 patches or more can end up running into several of that kind of problem and need several tries to get through. (For instance, you've got a windows build failure, which I'm about to send a separate mail for.) thanks -- PMM