qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Veres Lajos <vlajos@gmail.com>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
	Michael Tokarev <mjt@tls.msk.ru>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] typofixes
Date: Tue, 8 Sep 2015 19:10:45 +0100	[thread overview]
Message-ID: <CAFEAcA99zphfeH+DeBfNFQ3=_NRDMxCkmRtuQ=asWLjMdGY6Zg@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1509081856120.7825@citymarket.hu>

On 8 September 2015 at 19:01, Veres Lajos <vlajos@gmail.com> wrote:
> On Tue, 8 Sep 2015, Peter Maydell wrote:
>
>> Veres: can you drop the libvixl and linux-headers changes,
>> and at least split the remainder into docs/comments vs
>> code changes, and resend the patches to qemu-devel, please?
>
> I have removed the linux-headers/ and disas/libvixl/ changes.
> And I think the only non-comment/non-doc change is this:
> tests/qemu-iotests/041
> -    def test_unexistant_replaces(self):
> +    def test_unexistent_replaces(self):
>
> If you want I can move this to another patch.

OK, if there's just the one that's fine.

You forgot your signed-off-by line; we can't take the patch
without one. Also, please can you send it inline rather
than as an attachment? There are several places here which
want a better phrasing rather than just a typo fix, but
it's hard to comment on a patch provided as an attachment.

(For instance, that should be 'nonexistent', not
'unexistent' in that functionname; 'be deferring'
should be 'by deferring' in pl181.c, 'notable' should be
'notably' in various bits of decNumber.c, ...)

thanks
-- PMM

  reply	other threads:[~2015-09-08 18:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <alpine.DEB.2.02.1508092307540.14941@citymarket.hu>
     [not found] ` <alpine.DEB.2.02.1508102239060.14941@citymarket.hu>
2015-09-06 10:41   ` [Qemu-devel] typofixes Michael Tokarev
2015-09-07  6:47     ` Markus Armbruster
2015-09-07  8:14       ` Veres Lajos
2015-09-07 15:25         ` Markus Armbruster
2015-09-07 21:45 ` Veres Lajos
2015-09-08  7:17   ` Markus Armbruster
2015-09-08  8:26   ` Peter Maydell
2015-09-08 18:01     ` Veres Lajos
2015-09-08 18:10       ` Peter Maydell [this message]
2015-09-08 19:45       ` Eric Blake
2015-09-11  7:18     ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA99zphfeH+DeBfNFQ3=_NRDMxCkmRtuQ=asWLjMdGY6Zg@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=vlajos@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).