From: Peter Maydell <peter.maydell@linaro.org>
To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Cc: Thomas Huth <thuth@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Alistair Francis <alistair@alistair23.me>
Subject: Re: [Qemu-devel] [PATCH] hw/microblaze/xlnx-zynqmp-pmu: Fix introspection problem in 'xlnx, zynqmp-pmu-soc'
Date: Tue, 17 Jul 2018 20:41:05 +0100 [thread overview]
Message-ID: <CAFEAcA9=RNAjyiN5PT8cxU_rUk9ZGcSSJ2c4uW-V3VC+3SbLNw@mail.gmail.com> (raw)
In-Reply-To: <20180717173716.h2bhmmco7uoj2nvp@toto>
On 17 July 2018 at 18:37, Edgar E. Iglesias <edgar.iglesias@gmail.com> wrote:
> On Tue, Jul 17, 2018 at 04:55:43PM +0200, Thomas Huth wrote:
>> Valgrind complains:
>>
>> echo "{'execute':'qmp_capabilities'} {'execute':'device-list-properties'," \
>> "'arguments':{'typename':'xlnx,zynqmp-pmu-soc'}}" \
>> "{'execute': 'human-monitor-command', " \
>> "'arguments': {'command-line': 'info qtree'}}" | \
>> valgrind -q microblazeel-softmmu/qemu-system-microblazeel -M none,accel=qtest -qmp stdio
>> [...]
>> ==13605== Invalid read of size 8
>> ==13605== at 0x2AC69A: qdev_print (qdev-monitor.c:686)
>> ==13605== by 0x2AC69A: qbus_print (qdev-monitor.c:719)
>> ==13605== by 0x2591E8: handle_hmp_command (monitor.c:3446)
>>
>> Use the new object_initialize_child() and sysbus_init_child_obj() to
>> fix the issue.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>
>
> Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
>
> Peter, could you pick this up for 3.0? Or do you want a pull request?
It's missed rc1 but I'll put it in via target-arm.next for rc2.
thanks
-- PMM
prev parent reply other threads:[~2018-07-17 19:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 14:55 [Qemu-devel] [PATCH] hw/microblaze/xlnx-zynqmp-pmu: Fix introspection problem in 'xlnx, zynqmp-pmu-soc' Thomas Huth
2018-07-17 17:37 ` Edgar E. Iglesias
2018-07-17 19:41 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA9=RNAjyiN5PT8cxU_rUk9ZGcSSJ2c4uW-V3VC+3SbLNw@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=alistair@alistair23.me \
--cc=edgar.iglesias@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).