qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Thomas Huth <thuth@redhat.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@gmail.com>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Markus Armbruster" <armbru@redhat.com>
Subject: Re: meson.build files are missing copyright/license headers
Date: Tue, 25 Aug 2020 15:04:57 +0100	[thread overview]
Message-ID: <CAFEAcA9AMc62FhA8gn-=M2Jhe7Ahkf3AP-pWcJsYUEBLU=Jw3g@mail.gmail.com> (raw)
In-Reply-To: <ec7272ca-ffed-10b3-4176-8d2905d25772@redhat.com>

On Tue, 25 Aug 2020 at 14:58, Thomas Huth <thuth@redhat.com> wrote:
> On 25/08/2020 11.53, Peter Maydell wrote:
> >  * decide what our plan is for 3rd-party code (libvixl, etc)
> >    [where any SPDX line we add will be lost again next time
> >    we resync our copy of the code]
>
> For things like libvixl, I wonder why this is not a git submodule instead?

Because we only take a few files from it, not the whole thing
(which is massive and includes an assembler and a simulator).

> >  * update existing files (I think the kernel folks probably
> >    have scripted stuff for the easy parts of this; multi-license
> >    files like fpu/softfloat.c likely need by-hand conversion)
>
> Yes. I think we have to be very careful here with old files - adding the
> tags is likely ok, but e.g. removing the boilerplate text in the various
> headers at the same time could be problematic (e.g. the MIT license says
> "... this permission notice shall be included in all copies or
> substantial portions of the Software")...

Presumably the kernel folks have been down this route before us...

thanks
-- PMM


  reply	other threads:[~2020-08-25 14:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-24  9:43 meson.build files are missing copyright/license headers Peter Maydell
2020-08-24 18:29 ` Marc-André Lureau
2020-08-24 18:46   ` Peter Maydell
2020-08-25  5:57     ` Thomas Huth
2020-08-25  9:53       ` Peter Maydell
2020-08-25 13:58         ` Thomas Huth
2020-08-25 14:04           ` Peter Maydell [this message]
2020-08-25 14:15             ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA9AMc62FhA8gn-=M2Jhe7Ahkf3AP-pWcJsYUEBLU=Jw3g@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=armbru@redhat.com \
    --cc=marcandre.lureau@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).