From: Peter Maydell <peter.maydell@linaro.org>
To: Evgeny Voevodin <e.voevodin@samsung.com>
Cc: kyungmin.park@samsung.com, m.kozlov@samsung.com,
jehyung.lee@samsung.com, qemu-devel@nongnu.org,
d.solodkiy@samsung.com
Subject: Re: [Qemu-devel] [PATCH v7 07/10] ARM: exynos4210: MCT support.
Date: Wed, 18 Jan 2012 11:46:24 +0000 [thread overview]
Message-ID: <CAFEAcA9Agjsn1cbY8H4o5TcVTzGxT8J250GPSWD449UxNCasJA@mail.gmail.com> (raw)
In-Reply-To: <1326696515-6747-8-git-send-email-e.voevodin@samsung.com>
On 16 January 2012 06:48, Evgeny Voevodin <e.voevodin@samsung.com> wrote:
This doesn't compile on 32 bit hosts:
CC arm-softmmu/exynos4210_mct.o
cc1: warnings being treated as errors
/home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c: In
function ‘exynos4210_gcomp_get_distance’:
/home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c:485:
error: integer constant is too large for ‘long’ type
/home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c:487:
error: integer constant is too large for ‘long’ type
/home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c:490:
error: integer constant is too large for ‘long’ type
/home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c: In
function ‘exynos4210_gfrc_restart’:
/home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c:507:
error: integer constant is too large for ‘long’ type
/home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c:508:
error: integer constant is too large for ‘long’ type
/home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c: In
function ‘exynos4210_gfrc_event’:
/home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c:575:
error: integer constant is too large for ‘long’ type
/home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c:576:
error: integer constant is too large for ‘long’ type
/home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c: In
function ‘exynos4210_lfrc_update_count’:
/home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c:599:
error: integer constant is too large for ‘long’ type
/home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c: In
function ‘exynos4210_ltick_recalc_count’:
/home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c:843:
error: integer constant is too large for ‘long’ type
/home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c:845:
error: integer constant is too large for ‘long’ type
make[1]: *** [exynos4210_mct.o] Error 1
These two 64 bit constants need a ULL suffix:
> +#define MCT_GT_COUNTER_STEP 0x100000000
> +#define MCT_LT_COUNTER_STEP 0x100000000
-- PMM
next prev parent reply other threads:[~2012-01-18 11:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-16 6:48 [Qemu-devel] [PATCH v7 00/10] ARM: Samsung Exynos4210-based boards support Evgeny Voevodin
2012-01-16 6:48 ` [Qemu-devel] [PATCH v7 01/10] hw/sysbus.h: Increase maximum number of device IRQs Evgeny Voevodin
2012-01-17 1:15 ` andrzej zaborowski
2012-01-16 6:48 ` [Qemu-devel] [PATCH v7 02/10] hw/arm_boot.c: Make SMP boards specify address to poll in bootup loop Evgeny Voevodin
2012-01-16 6:48 ` [Qemu-devel] [PATCH v7 03/10] ARM: exynos4210: IRQ subsystem support Evgeny Voevodin
2012-01-16 6:48 ` [Qemu-devel] [PATCH v7 04/10] ARM: Samsung exynos4210-based boards emulation Evgeny Voevodin
2012-01-16 6:48 ` [Qemu-devel] [PATCH v7 05/10] ARM: exynos4210: UART support Evgeny Voevodin
2012-01-16 6:48 ` [Qemu-devel] [PATCH v7 06/10] ARM: exynos4210: PWM support Evgeny Voevodin
2012-01-16 6:48 ` [Qemu-devel] [PATCH v7 07/10] ARM: exynos4210: MCT support Evgeny Voevodin
2012-01-18 11:46 ` Peter Maydell [this message]
2012-01-19 7:19 ` Evgeny Voevodin
2012-01-16 6:48 ` [Qemu-devel] [PATCH v7 08/10] hw/lan9118: Add basic 16-bit mode support Evgeny Voevodin
2012-01-16 6:48 ` [Qemu-devel] [PATCH v7 09/10] hw/exynos4210.c: Add LAN support for SMDKC210 Evgeny Voevodin
2012-01-18 11:55 ` Peter Maydell
2012-01-16 6:48 ` [Qemu-devel] [PATCH v7 10/10] Exynos4210: added display controller implementation Evgeny Voevodin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA9Agjsn1cbY8H4o5TcVTzGxT8J250GPSWD449UxNCasJA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=d.solodkiy@samsung.com \
--cc=e.voevodin@samsung.com \
--cc=jehyung.lee@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=m.kozlov@samsung.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).