From: Peter Maydell <peter.maydell@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-trivial@nongnu.org, patches@linaro.org,
qemu-devel@nongnu.org, Yurij Popov <oss@djphoenix.ru>
Subject: Re: [Qemu-devel] [PATCH] qemu-timer: Don't use RDTSC on 386s and 486s
Date: Fri, 23 Nov 2012 15:17:47 +0000 [thread overview]
Message-ID: <CAFEAcA9AnUrbrOKrJx7pkg9j1Ex3Ou2d23ROsn82TJa4Wdrf_Q@mail.gmail.com> (raw)
In-Reply-To: <50AF931B.8080707@redhat.com>
On 23 November 2012 15:15, Paolo Bonzini <pbonzini@redhat.com> wrote:
> Il 23/11/2012 16:12, Peter Maydell ha scritto:
>> Adjust the conditional which guards the implementation of
>>
>> -#elif defined(__i386__)
>> +#elif defined(__i586__)
>>
>> static inline int64_t cpu_get_real_ticks(void)
>> {
>>
>
> You should at least test __i686__ too:
>
> $ gcc -m32 -dM -E -x c /dev/null |grep __i
> #define __i686 1
> #define __i686__ 1
> #define __i386 1
> #define __i386__ 1
Yuck. I had assumed gcc would define everything from i386
on up when building for later cores.
-- PMM
next prev parent reply other threads:[~2012-11-23 15:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-23 15:12 [Qemu-devel] [PATCH] qemu-timer: Don't use RDTSC on 386s and 486s Peter Maydell
2012-11-23 15:15 ` Paolo Bonzini
2012-11-23 15:17 ` Peter Maydell [this message]
2012-11-23 15:31 ` Jamie Lokier
2012-11-23 15:38 ` Peter Maydell
2012-11-23 16:21 ` Jamie Lokier
2012-11-23 15:37 ` Peter Maydell
2012-11-23 16:19 ` Jamie Lokier
2012-11-24 17:39 ` [Qemu-devel] [PATCH] tcg-i386: Improve cmov detection Richard Henderson
2012-11-24 18:12 ` Peter Maydell
2012-11-26 16:23 ` Richard Henderson
2012-12-10 15:42 ` 陳韋任 (Wei-Ren Chen)
2012-11-25 13:44 ` Aurelien Jarno
2012-12-03 13:00 ` [Qemu-devel] [Qemu-trivial] [PATCH] qemu-timer: Don't use RDTSC on 386s and 486s Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA9AnUrbrOKrJx7pkg9j1Ex3Ou2d23ROsn82TJa4Wdrf_Q@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=oss@djphoenix.ru \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).