From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tbv0r-0003Qw-2d for qemu-devel@nongnu.org; Fri, 23 Nov 2012 10:17:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tbv0n-0005ZK-0p for qemu-devel@nongnu.org; Fri, 23 Nov 2012 10:17:52 -0500 Received: from mail-ie0-f173.google.com ([209.85.223.173]:61823) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tbv0m-0005ZB-S4 for qemu-devel@nongnu.org; Fri, 23 Nov 2012 10:17:48 -0500 Received: by mail-ie0-f173.google.com with SMTP id e13so3217700iej.4 for ; Fri, 23 Nov 2012 07:17:48 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <50AF931B.8080707@redhat.com> References: <1353683570-30525-1-git-send-email-peter.maydell@linaro.org> <50AF931B.8080707@redhat.com> Date: Fri, 23 Nov 2012 15:17:47 +0000 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH] qemu-timer: Don't use RDTSC on 386s and 486s List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-trivial@nongnu.org, patches@linaro.org, qemu-devel@nongnu.org, Yurij Popov On 23 November 2012 15:15, Paolo Bonzini wrote: > Il 23/11/2012 16:12, Peter Maydell ha scritto: >> Adjust the conditional which guards the implementation of >> >> -#elif defined(__i386__) >> +#elif defined(__i586__) >> >> static inline int64_t cpu_get_real_ticks(void) >> { >> > > You should at least test __i686__ too: > > $ gcc -m32 -dM -E -x c /dev/null |grep __i > #define __i686 1 > #define __i686__ 1 > #define __i386 1 > #define __i386__ 1 Yuck. I had assumed gcc would define everything from i386 on up when building for later cores. -- PMM