From: Peter Maydell <peter.maydell@linaro.org>
To: Alexander Graf <agraf@suse.de>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
Heinz Graalfs <graalfs@linux.vnet.ibm.com>,
"qemu-devel@nongnu.org qemu-devel" <qemu-devel@nongnu.org>,
Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 06/24] Remove local ram_size that hides global one
Date: Mon, 19 Nov 2012 13:20:07 +0000 [thread overview]
Message-ID: <CAFEAcA9BkkLBLFjzUuPLsaLKdFuXxAHrsWzij--qDXNY7D9v4A@mail.gmail.com> (raw)
In-Reply-To: <3CA9BC2F-0996-46CA-AB82-BFE7D3364272@suse.de>
On 19 November 2012 13:14, Alexander Graf <agraf@suse.de> wrote:
>
> On 13.11.2012, at 13:11, Christian Borntraeger wrote:
>
>> From: Heinz Graalfs <graalfs@linux.vnet.ibm.com>
>>
>> The global variable 'ram_size' is hidden by the local variable
>> declaration in s390_init()
>
> That's the point of Eduardo's patch, no? Or do we need access
> to the global to change its value afterwards?
The function later does:
/* lets propagate the changed ram size into the global variable. */
ram_size = my_ram_size;
which frankly I think is pretty nasty but then we've never
had a very good mechanism for specifying board-specific
restrictions around the memory size.
-- PMM
next prev parent reply other threads:[~2012-11-19 13:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 12:11 [Qemu-devel] [PATCH 06/24] Remove local ram_size that hides global one Christian Borntraeger
2012-11-19 13:14 ` Alexander Graf
2012-11-19 13:20 ` Peter Maydell [this message]
2012-11-19 13:35 ` Eduardo Habkost
2012-11-19 13:46 ` Alexander Graf
2012-11-20 9:28 ` [Qemu-devel] [PATCH 1/1] s390: Fix ram_size updating in machine init Christian Borntraeger
2012-11-20 9:31 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA9BkkLBLFjzUuPLsaLKdFuXxAHrsWzij--qDXNY7D9v4A@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=ehabkost@redhat.com \
--cc=graalfs@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).