From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33262)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1TaRGn-0006Kp-H2
	for qemu-devel@nongnu.org; Mon, 19 Nov 2012 08:20:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1TaRGk-0004RR-FV
	for qemu-devel@nongnu.org; Mon, 19 Nov 2012 08:20:13 -0500
Received: from mail-ia0-f173.google.com ([209.85.210.173]:46100)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1TaRGk-0004QV-Ad
	for qemu-devel@nongnu.org; Mon, 19 Nov 2012 08:20:10 -0500
Received: by mail-ia0-f173.google.com with SMTP id w21so2071790iac.4
	for <qemu-devel@nongnu.org>; Mon, 19 Nov 2012 05:20:08 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <3CA9BC2F-0996-46CA-AB82-BFE7D3364272@suse.de>
References: <1352808709-11215-1-git-send-email-borntraeger@de.ibm.com>
	<3CA9BC2F-0996-46CA-AB82-BFE7D3364272@suse.de>
Date: Mon, 19 Nov 2012 13:20:07 +0000
Message-ID: <CAFEAcA9BkkLBLFjzUuPLsaLKdFuXxAHrsWzij--qDXNY7D9v4A@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 06/24] Remove local ram_size that hides
 global one
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>, Heinz Graalfs <graalfs@linux.vnet.ibm.com>, "qemu-devel@nongnu.org qemu-devel" <qemu-devel@nongnu.org>, Eduardo Habkost <ehabkost@redhat.com>

On 19 November 2012 13:14, Alexander Graf <agraf@suse.de> wrote:
>
> On 13.11.2012, at 13:11, Christian Borntraeger wrote:
>
>> From: Heinz Graalfs <graalfs@linux.vnet.ibm.com>
>>
>> The global variable 'ram_size' is hidden by the local variable
>> declaration in s390_init()
>
> That's the point of Eduardo's patch, no? Or do we need access
> to the global to change its value afterwards?

The function later does:
    /* lets propagate the changed ram size into the global variable. */
    ram_size = my_ram_size;

which frankly I think is pretty nasty but then we've never
had a very good mechanism for specifying board-specific
restrictions around the memory size.

-- PMM