From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50650)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Vsyuq-0003qH-KQ
	for qemu-devel@nongnu.org; Tue, 17 Dec 2013 12:58:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Vsyul-00023S-S3
	for qemu-devel@nongnu.org; Tue, 17 Dec 2013 12:58:44 -0500
Received: from mail-pb0-f51.google.com ([209.85.160.51]:37782)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Vsyul-00023M-La
	for qemu-devel@nongnu.org; Tue, 17 Dec 2013 12:58:39 -0500
Received: by mail-pb0-f51.google.com with SMTP id up15so7254241pbc.24
	for <qemu-devel@nongnu.org>; Tue, 17 Dec 2013 09:58:38 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1387301460-28164-2-git-send-email-stefano.stabellini@eu.citrix.com>
References: <alpine.DEB.2.02.1312171724460.8667@kaball.uk.xensource.com>
	<1387301460-28164-2-git-send-email-stefano.stabellini@eu.citrix.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Tue, 17 Dec 2013 17:58:18 +0000
Message-ID: <CAFEAcA9CfHGBCmdt8XcTv_tPCeJ3FN1Udoa-1KcDUhE5WyGa7Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 2/2] xen: build on ARM
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>, "xen-devel@lists.xensource.com Devel" <xen-devel@lists.xensource.com>, QEMU Developers <qemu-devel@nongnu.org>

On 17 December 2013 17:31, Stefano Stabellini
<stefano.stabellini@eu.citrix.com> wrote:
> - add __arm__ and __aarch64__ cases in xen-mapcache.c.
> --- a/xen-mapcache.c
> +++ b/xen-mapcache.c
> @@ -33,10 +33,10 @@
>  #  define DPRINTF(fmt, ...) do { } while (0)
>  #endif
>
> -#if defined(__i386__)
> +#if defined(__i386__) || defined(__arm__)
>  #  define MCACHE_BUCKET_SHIFT 16
>  #  define MCACHE_MAX_SIZE     (1UL<<31) /* 2GB Cap */
> -#elif defined(__x86_64__)
> +#elif defined(__x86_64__) || defined(__aarch64__)
>  #  define MCACHE_BUCKET_SHIFT 20
>  #  define MCACHE_MAX_SIZE     (1UL<<35) /* 32GB Cap */
>  #endif

Per-host-architecture ifdef ladders are kind of nasty. What's this
code actually trying to do ? (looks like maybe "64 bit host addresses
vs 32 bit host addresses" ?)

thanks
-- PMM