From: Peter Maydell <peter.maydell@linaro.org>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Paul Brook <paul@codesourcery.com>,
Richard Cole <richard.j.cole@gmail.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] DMA active hw_error
Date: Tue, 27 Dec 2011 22:27:30 +0000 [thread overview]
Message-ID: <CAFEAcA9Ckvm2oPUdF_gZzL5r2TabcytWojjCY6etRRNEhEeSnw@mail.gmail.com> (raw)
In-Reply-To: <4EF9D721.6080800@suse.de>
On 27 December 2011 14:33, Andreas Färber <afaerber@suse.de> wrote:
> Further down, this also looks odd:
>
> if (s->conf & (PL080_CONF_M1 | PL080_CONF_M1)) {
> hw_error("pl080_write: Big-endian DMA not implemented\n");
> }
>
> Maybe (..._M1 | ..._M2)?
Yes, obvious typo. I've noticed that one before but hadn't got
round to submitting a patch to fix it, since it's only guarding
a "this is broken" assert.
-- PMM
next prev parent reply other threads:[~2011-12-27 22:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-27 2:26 [Qemu-devel] DMA active hw_error Richard Cole
2011-12-27 3:21 ` Richard Cole
2011-12-27 22:39 ` Peter Maydell
2011-12-28 6:44 ` Richard Cole
2011-12-28 11:32 ` Peter Maydell
2011-12-27 14:33 ` Andreas Färber
2011-12-27 22:27 ` Peter Maydell [this message]
2011-12-27 22:19 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA9Ckvm2oPUdF_gZzL5r2TabcytWojjCY6etRRNEhEeSnw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=afaerber@suse.de \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.j.cole@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).