From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3998CC678D4 for ; Mon, 6 Mar 2023 13:24:43 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZAp4-0004Og-5a; Mon, 06 Mar 2023 08:24:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZAoz-00044i-Bk for qemu-devel@nongnu.org; Mon, 06 Mar 2023 08:24:10 -0500 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZAow-0005yc-L9 for qemu-devel@nongnu.org; Mon, 06 Mar 2023 08:24:09 -0500 Received: by mail-pj1-x102e.google.com with SMTP id x34so9771875pjj.0 for ; Mon, 06 Mar 2023 05:24:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678109042; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=eKUeXLHYw4kcMo3qEaxFcTYdTG5rKraGNLJFumtHOEw=; b=Hgw7XhJK6Cd8dDATYdxGWr9EB0FomSgSen7oJBiXT4Y7rFDsSmWq18z4VMRJ6Sf0Dj x7qm84KQ18XDfYHelhxUV8LKydtaCpSYr1L6VVWCzRqRuoOJY+97Hq5blVtZ1ZcS5O+h SXfuUEXp5OEOD89L0r4TyqYRR0U0g4FFXpFun3XFj+HOeVwZwgURimskZ7An0ChjRVey Sz3Jx+P9z42UxQT4VM77sk4LedibXI5OrFEFgu1FuYPEfHjjJNoS6RRIyQ0ZyTFL/FYg wElguc8oo2NlPkpIsefk4mfOejCqGt7lSgsxq0fF0qaShRL4JFIFJoIe6Wl7FogDV/Yx Tk9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678109042; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eKUeXLHYw4kcMo3qEaxFcTYdTG5rKraGNLJFumtHOEw=; b=NXjEPH7xW0YElMcNNOpAKs0xd5mLVciqZyUHrAHrG1pt/2o+HEyepN0usX6MDI6hcx jczHD9a0xpCOoFvKiEJZevoac+U9alIyzmqUWNm6ij4P0tjyB92NSl1klRRB019xdi2B oXDa8yDxIZaseTvVJWYjb1aJS18QjqUVyOPTaQLxS7J2MeiFhVWyWLA7c0XZOGD9aZiS 8VM6zMbF99Qdyiy/VLucmr8Jap/NzJVDQfxUs2U1YGV4P9AOBeoQI3YwR8I7mGDMH3fv Kxqk7e75kQyzm8wmfWjxK/cjYP0l9CR7egZH1sigirMMyBy4pwpXT7/Me5DxJMQOqYyp RkOw== X-Gm-Message-State: AO0yUKUeHgwFStyBME1PBkUGSyejfkuAPjNXBXF1gE3iJWGb5CjupQOU pA3xd+mmh5rzBCHOKxkxUZI46SDxBX1piAboNO8VHw== X-Google-Smtp-Source: AK7set+dwNZCwDDoqWuS6uM0UlVptriox91v35fx7NqMLsq7RD6J5WVu49UEhrzwmElyeXwBD1Ci3HstDGg7OUXdOXU= X-Received: by 2002:a17:902:a3c6:b0:19b:8cbb:30fe with SMTP id q6-20020a170902a3c600b0019b8cbb30femr4219865plb.13.1678109042316; Mon, 06 Mar 2023 05:24:02 -0800 (PST) MIME-Version: 1.0 References: <20230220081252.25348-1-qianfanguijin@163.com> <20230220081252.25348-2-qianfanguijin@163.com> In-Reply-To: <20230220081252.25348-2-qianfanguijin@163.com> From: Peter Maydell Date: Mon, 6 Mar 2023 13:23:51 +0000 Message-ID: Subject: Re: [PATCH v2 2/3] hw: allwinner-i2c: Fix TWI_CNTR_INT_FLAG on SUN6i SoCs To: qianfanguijin@163.com Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, Strahinja Jankovic , Beniamino Galvani Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::102e; envelope-from=peter.maydell@linaro.org; helo=mail-pj1-x102e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, 20 Feb 2023 at 08:13, wrote: > > From: qianfan Zhao > > TWI_CNTR_INT_FLAG is W1C(write 1 to clear and write 0 has non-effect) > register on SUN6i based SoCs, we should lower interrupt when the guest > set this bit. > > The linux kernel will hang in irq handler(mv64xxx_i2c_intr) if no > device connected on the i2c bus, next is the trace log: > > allwinner_i2c_write write CNTR(0x0c): 0xc4 A_ACK BUS_EN INT_EN > allwinner_i2c_write write CNTR(0x0c): 0xcc A_ACK INT_FLAG BUS_EN INT_EN > allwinner_i2c_read read CNTR(0x0c): 0xcc A_ACK INT_FLAG BUS_EN INT_EN > allwinner_i2c_read read STAT(0x10): 0x20 STAT_M_ADDR_WR_NACK > allwinner_i2c_write write CNTR(0x0c): 0x54 A_ACK M_STP BUS_EN > allwinner_i2c_write write CNTR(0x0c): 0x4c A_ACK INT_FLAG BUS_EN > allwinner_i2c_read read CNTR(0x0c): 0x4c A_ACK INT_FLAG BUS_EN > allwinner_i2c_read read STAT(0x10): 0xf8 STAT_IDLE > allwinner_i2c_write write CNTR(0x0c): 0x54 A_ACK M_STP BUS_EN > allwinner_i2c_write write CNTR(0x0c): 0x4c A_ACK INT_FLAG BUS_EN > allwinner_i2c_read read CNTR(0x0c): 0x4c A_ACK INT_FLAG BUS_EN > allwinner_i2c_read read STAT(0x10): 0xf8 STAT_IDLE > ... > > Fix it. > > Signed-off-by: qianfan Zhao Reviewed-by: Peter Maydell thanks -- PMM