qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Joel Fernandes <joelf@ti.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
	Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [Qemu-devel] [PATCH] QEMU: ARM: boot: Load kernel at an Image friendly address
Date: Tue, 1 Apr 2014 18:10:59 +0100	[thread overview]
Message-ID: <CAFEAcA9Dc5bN_JdMNWODB9Puj9HLoEBm4mDo7ZcaJj97qBbAdw@mail.gmail.com> (raw)
In-Reply-To: <1395718484-20424-1-git-send-email-joelf@ti.com>

On 25 March 2014 03:34, Joel Fernandes <joelf@ti.com> wrote:
> Loading kernel at offset 0x10000 works only for zImage, but not for Image,
> because the kernel expect the start of decompressed kernel (.head.text) to be
> at an address that's a distance that's 16MB aligned from  PAGE_OFFSET +
> TEXT_OFFSET (see vmlinux.lds.S). This check is enfornced in __fixup_pv_table in
> arch/arm/kernel/head.S TEXT_OFFSET is 0x00008000, so a 16MB alignment needs to
> have a "0x8000" in the lower 16 bits so that they cancel out. Currently the
> offset Qemu loads it at is 0x10000.
>
> With zImage, this need is met because zImage loads the uncompressed Image
> correctly, however when loading an Image and executing directly Qemu is
> required it to load it at the correct location. Doing so, doesn't break Qemu's
> zImage loading. With this patch, both zImage and Image work correctly.
>
> Signed-off-by: Joel Fernandes <joelf@ti.com>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

I'll put this in target-arm.next after 2.0 has released.

thanks
-- PMM

  parent reply	other threads:[~2014-04-01 17:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-25  3:34 [Qemu-devel] [PATCH] QEMU: ARM: boot: Load kernel at an Image friendly address Joel Fernandes
2014-03-25 12:29 ` Christopher Covington
2014-03-25 13:43   ` Joel Fernandes
2014-03-25 13:13 ` Peter Maydell
2014-03-25 13:46   ` Joel Fernandes
2014-04-01 17:10 ` Peter Maydell [this message]
2014-04-02 12:11   ` Peter Crosthwaite
2014-04-02 12:47     ` Peter Maydell
2014-04-02 12:58       ` Peter Crosthwaite
2014-04-02 15:04       ` Christopher Covington
2014-04-02 16:06       ` Joel Fernandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA9Dc5bN_JdMNWODB9Puj9HLoEBm4mDo7ZcaJj97qBbAdw@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=joelf@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).