From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39061)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1WV2Dc-0007Gd-MX
	for qemu-devel@nongnu.org; Tue, 01 Apr 2014 13:11:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1WV2DY-0007pK-Es
	for qemu-devel@nongnu.org; Tue, 01 Apr 2014 13:11:24 -0400
Received: from mail-la0-f53.google.com ([209.85.215.53]:60337)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1WV2DY-0007p9-7o
	for qemu-devel@nongnu.org; Tue, 01 Apr 2014 13:11:20 -0400
Received: by mail-la0-f53.google.com with SMTP id b8so7329230lan.12
	for <qemu-devel@nongnu.org>; Tue, 01 Apr 2014 10:11:19 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1395718484-20424-1-git-send-email-joelf@ti.com>
References: <1395718484-20424-1-git-send-email-joelf@ti.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Tue, 1 Apr 2014 18:10:59 +0100
Message-ID: <CAFEAcA9Dc5bN_JdMNWODB9Puj9HLoEBm4mDo7ZcaJj97qBbAdw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH] QEMU: ARM: boot: Load kernel at an Image
	friendly address
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Joel Fernandes <joelf@ti.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>

On 25 March 2014 03:34, Joel Fernandes <joelf@ti.com> wrote:
> Loading kernel at offset 0x10000 works only for zImage, but not for Image,
> because the kernel expect the start of decompressed kernel (.head.text) to be
> at an address that's a distance that's 16MB aligned from  PAGE_OFFSET +
> TEXT_OFFSET (see vmlinux.lds.S). This check is enfornced in __fixup_pv_table in
> arch/arm/kernel/head.S TEXT_OFFSET is 0x00008000, so a 16MB alignment needs to
> have a "0x8000" in the lower 16 bits so that they cancel out. Currently the
> offset Qemu loads it at is 0x10000.
>
> With zImage, this need is met because zImage loads the uncompressed Image
> correctly, however when loading an Image and executing directly Qemu is
> required it to load it at the correct location. Doing so, doesn't break Qemu's
> zImage loading. With this patch, both zImage and Image work correctly.
>
> Signed-off-by: Joel Fernandes <joelf@ti.com>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

I'll put this in target-arm.next after 2.0 has released.

thanks
-- PMM