From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43757)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1WX7I6-0003GH-8x
	for qemu-devel@nongnu.org; Mon, 07 Apr 2014 07:00:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1WX7I0-0004JC-4a
	for qemu-devel@nongnu.org; Mon, 07 Apr 2014 07:00:38 -0400
Received: from mail-la0-f53.google.com ([209.85.215.53]:48485)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1WX7Hz-0004J3-QT
	for qemu-devel@nongnu.org; Mon, 07 Apr 2014 07:00:32 -0400
Received: by mail-la0-f53.google.com with SMTP id b8so4528112lan.26
	for <qemu-devel@nongnu.org>; Mon, 07 Apr 2014 04:00:30 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1396840915-10384-3-git-send-email-quintela@redhat.com>
References: <1396840915-10384-1-git-send-email-quintela@redhat.com>
	<1396840915-10384-3-git-send-email-quintela@redhat.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 7 Apr 2014 12:00:10 +0100
Message-ID: <CAFEAcA9Fa5ntLy7ktQjnrxdxoueecSqi_W6yTe-78PFWHd=cfA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 02/97] savevm: Remove all the unneded
 version_minimum_id_old (Massive)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On 7 April 2014 04:20, Juan Quintela <quintela@redhat.com> wrote:
> After previous Peter patch, they are redundant.  This way we don't asign them
> except when needed.  Once there, there were lots of case where the ".fields"
> indentation was wrong:
>
>      .fields = (VMStateField []) {
> and
>      .fields =      (VMStateField []) {
>
> Change all the combinations to:
>
>      .fields = (VMStateField[]){
>
> The biggest problem (appart of aesthetics) was that checkpatch complained
> when we copy&pasted the code from one place to another.
>
>  211 files changed, 289 insertions(+), 621 deletions(-)

I'm really not a fan of this kind of single patch that
touches a huge number of files at once. They're basically
impossible to review and they introduce the possibility
of conflicts between submaintainer tree changes and the
big patch. There's no reason to have all these changes
in a single patch -- I'd much rather see one patch per
subsystem sent to the relevant submaintainers, plus
one for all the unmaintained stuff which can go via
the migration tree.

thanks
-- PMM