From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58685)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YlLfW-00039i-FF
	for qemu-devel@nongnu.org; Thu, 23 Apr 2015 14:16:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YlLfS-0002W7-8Y
	for qemu-devel@nongnu.org; Thu, 23 Apr 2015 14:16:10 -0400
Received: from mail-ig0-f178.google.com ([209.85.213.178]:37020)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YlLfS-0002Vw-4g
	for qemu-devel@nongnu.org; Thu, 23 Apr 2015 14:16:06 -0400
Received: by igblo3 with SMTP id lo3so30172371igb.0
	for <qemu-devel@nongnu.org>; Thu, 23 Apr 2015 11:16:00 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <8f036aa5e8b618bcce048c1ca9ce629ec49aad31.1427108387.git.peter.crosthwaite@xilinx.com>
References: <cover.1427108387.git.peter.crosthwaite@xilinx.com>
	<8f036aa5e8b618bcce048c1ca9ce629ec49aad31.1427108387.git.peter.crosthwaite@xilinx.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Thu, 23 Apr 2015 19:15:40 +0100
Message-ID: <CAFEAcA9FnjTxiGStruowViahNC08C0sjreqxbdJaOxGsW6poVw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH target-arm v4 15/16] arm: xilinx-ep108: Add
	bootloading
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: Edgar Iglesias <edgar.iglesias@xilinx.com>, Ryota Ozaki <ozaki.ryota@gmail.com>, michals@xilinx.com, QEMU Developers <qemu-devel@nongnu.org>, zach.pfeffer@xilinx.com

On 23 March 2015 at 11:05, Peter Crosthwaite
<peter.crosthwaite@xilinx.com> wrote:
> Using standard ARM bootloader.

Commit msg, etc.

> Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> ---
>  hw/arm/xlnx-ep108.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/hw/arm/xlnx-ep108.c b/hw/arm/xlnx-ep108.c
> index 6e89456..a86f595 100644
> --- a/hw/arm/xlnx-ep108.c
> +++ b/hw/arm/xlnx-ep108.c
> @@ -28,6 +28,8 @@ typedef struct XlnxEP108 {
>  /* Max 2GB RAM */
>  #define EP108_MAX_RAM_SIZE 0x80000000ull
>
> +static struct arm_boot_info xlnx_ep108_binfo;
> +
>  static void xlnx_ep108_init(MachineState *machine)
>  {
>      XlnxEP108 *s = g_new0(XlnxEP108, 1);
> @@ -58,6 +60,12 @@ static void xlnx_ep108_init(MachineState *machine)
>                             &error_abort);
>      vmstate_register_ram_global(&s->ddr_ram);
>      memory_region_add_subregion(get_system_memory(), 0, &s->ddr_ram);
> +
> +    xlnx_ep108_binfo.ram_size = machine->ram_size;
> +    xlnx_ep108_binfo.kernel_filename = machine->kernel_filename;
> +    xlnx_ep108_binfo.kernel_cmdline = machine->kernel_cmdline;
> +    xlnx_ep108_binfo.initrd_filename = machine->initrd_filename;

nb_cpus, loader_start ?

> +    arm_load_kernel(&s->soc.cpu[0], &xlnx_ep108_binfo);
>  }
>
>  static QEMUMachine xlnx_ep108_machine = {
> --
> 2.3.1.2.g90df61e.dirty

thanks
-- PMM