From: Peter Maydell <peter.maydell@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] elf-ops.h: fix int overflow in load_elf()
Date: Tue, 10 Sep 2019 10:54:25 +0100 [thread overview]
Message-ID: <CAFEAcA9GMtuDCZVLFECnT0uF377_T0T_-Bn_9-RvC-zHRihqSA@mail.gmail.com> (raw)
In-Reply-To: <87mufc1nvd.fsf@linaro.org>
On Tue, 10 Sep 2019 at 10:50, Alex Bennée <alex.bennee@linaro.org> wrote:
> Seem sensible enough (although gah, I hate these glue bits). Would the
> large amount of goto fail logic be something that could be cleaned up
> with the automatic cleanup functions we recently mentioned in
> CODING_STYLE.rst?
Probably not, because one bit of cleanup we *should* be doing
in the fail-exit codepaths but currently don't is to delete
any rom blobs we created for earlier segments in the ELF file
before we gave up, so we need to have an error-exit path anyway...
thanks
-- PMM
next prev parent reply other threads:[~2019-09-10 9:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 9:08 [Qemu-devel] [PATCH] elf-ops.h: fix int overflow in load_elf() Stefano Garzarella
2019-09-10 9:37 ` Peter Maydell
2019-09-10 9:47 ` Stefano Garzarella
2019-09-10 9:50 ` Alex Bennée
2019-09-10 9:53 ` Daniel P. Berrangé
2019-09-10 9:54 ` Peter Maydell [this message]
2019-09-10 11:02 ` Stefano Garzarella
2019-09-10 11:07 ` Stefano Garzarella
2019-09-10 12:12 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA9GMtuDCZVLFECnT0uF377_T0T_-Bn_9-RvC-zHRihqSA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).