From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58051) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cTCwR-00089h-QR for qemu-devel@nongnu.org; Mon, 16 Jan 2017 14:27:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cTCwR-0000s6-28 for qemu-devel@nongnu.org; Mon, 16 Jan 2017 14:27:43 -0500 Received: from mail-vk0-x232.google.com ([2607:f8b0:400c:c05::232]:34339) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cTCwQ-0000r7-Un for qemu-devel@nongnu.org; Mon, 16 Jan 2017 14:27:42 -0500 Received: by mail-vk0-x232.google.com with SMTP id r136so79221847vke.1 for ; Mon, 16 Jan 2017 11:27:42 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20170116192520.GB3491@thinpad.lan.raisama.net> References: <1484376662-32063-1-git-send-email-thuth@redhat.com> <2296ffa3-8bb9-4652-ebd6-4da5b09596ca@vivier.eu> <1ed4fded-4468-16cd-96e2-f70c1b85ab7d@redhat.com> <20170116192520.GB3491@thinpad.lan.raisama.net> From: Peter Maydell Date: Mon, 16 Jan 2017 19:27:21 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH] hw/core/null-machine: Add the possibility to instantiate a CPU, RAM and kernel List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Alistair Francis , Thomas Huth , Laurent Vivier , "qemu-devel@nongnu.org Developers" , Markus Armbruster , Max Filippov , Paolo Bonzini On 16 January 2017 at 19:25, Eduardo Habkost wrote: > On Mon, Jan 16, 2017 at 10:53:07AM -0800, Alistair Francis wrote: >> On Sun, Jan 15, 2017 at 11:59 PM, Thomas Huth wrote: >> > But I think the users also expect the "-kernel" parameter to be working, >> > so I think we should add the loader code in null-machine.c anyway. >> >> I agree that uses probably expect the '-kernel' option to work as well. > > So, is it possible to write a generic load_kernel() function that > simply reuses the generic-loader code? No, because users expect -kernel to actually load a Linux kernel (meaning with the calling conventions etc the kernel requires), whereas generic-loader is just "load a binary blob and start there". (-kernel is arch-specific and messy and doesn't behave the same way on all targets either :-() thanks -- PMM