From: Peter Maydell <peter.maydell@linaro.org>
To: pavel.zbitskiy@gmail.com
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/3] linux-user: fixed s390x clone() argument order
Date: Sun, 12 Jan 2014 18:56:50 +0000 [thread overview]
Message-ID: <CAFEAcA9GkEf8gKXrzAepyqO6YLLLpD+eavGH1_EF602aDhAoZg@mail.gmail.com> (raw)
In-Reply-To: <1389432851-11420-2-git-send-email-pavel.zbitskiy@gmail.com>
On 11 January 2014 09:34, <pavel.zbitskiy@gmail.com> wrote:
> From: Pavel Zbitskiy <pavel.zbitskiy@gmail.com>
>
> It was broken by 4ce6243dc6216e35b5b691078ffa856463bfa8db,
> where TARGET_CLONE_BACKWARDS was specified instead of
> TARGET_CLONE_BACKWARDS2.
>
> Signed-off-by: Pavel Zbitskiy <pavel.zbitskiy@gmail.com>
> ---
> linux-user/s390x/syscall.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/s390x/syscall.h b/linux-user/s390x/syscall.h
> index ea8c304..e5ce30b 100644
> --- a/linux-user/s390x/syscall.h
> +++ b/linux-user/s390x/syscall.h
> @@ -22,4 +22,4 @@ struct target_pt_regs {
>
> #define UNAME_MACHINE "s390x"
>
> -#define TARGET_CLONE_BACKWARDS
> +#define TARGET_CLONE_BACKWARDS2
Yep, kernel config agrees:
http://lxr.free-electrons.com/source/arch/s390/Kconfig#L99
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
next prev parent reply other threads:[~2014-01-12 18:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-11 9:34 [Qemu-devel] [PATCH 0/3] Fix networking for s390x-user pavel.zbitskiy
2014-01-11 9:34 ` [Qemu-devel] [PATCH 1/3] linux-user: fixed s390x clone() argument order pavel.zbitskiy
2014-01-12 18:56 ` Peter Maydell [this message]
2014-01-11 9:34 ` [Qemu-devel] [PATCH 2/3] linux-user: fixed getsockopt() optlen pavel.zbitskiy
2014-01-12 19:07 ` Peter Maydell
2014-01-15 19:37 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-01-11 9:34 ` [Qemu-devel] [PATCH 3/3] linux-user: fixed recvfrom() addrlen pavel.zbitskiy
2014-01-15 19:38 ` [Qemu-devel] [Qemu-trivial] [PATCH 0/3] Fix networking for s390x-user Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA9GkEf8gKXrzAepyqO6YLLLpD+eavGH1_EF602aDhAoZg@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=pavel.zbitskiy@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).