From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37636)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1W2QDl-0002ui-Ij
	for qemu-devel@nongnu.org; Sun, 12 Jan 2014 13:57:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1W2QDh-0003eW-7O
	for qemu-devel@nongnu.org; Sun, 12 Jan 2014 13:57:17 -0500
Received: from mail-lb0-f172.google.com ([209.85.217.172]:54218)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1W2QDg-0003eI-W4
	for qemu-devel@nongnu.org; Sun, 12 Jan 2014 13:57:13 -0500
Received: by mail-lb0-f172.google.com with SMTP id c11so501084lbj.3
	for <qemu-devel@nongnu.org>; Sun, 12 Jan 2014 10:57:11 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1389432851-11420-2-git-send-email-pavel.zbitskiy@gmail.com>
References: <1389432851-11420-1-git-send-email-pavel.zbitskiy@gmail.com>
	<1389432851-11420-2-git-send-email-pavel.zbitskiy@gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Sun, 12 Jan 2014 18:56:50 +0000
Message-ID: <CAFEAcA9GkEf8gKXrzAepyqO6YLLLpD+eavGH1_EF602aDhAoZg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 1/3] linux-user: fixed s390x clone()
	argument order
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: pavel.zbitskiy@gmail.com
Cc: QEMU Trivial <qemu-trivial@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>

On 11 January 2014 09:34,  <pavel.zbitskiy@gmail.com> wrote:
> From: Pavel Zbitskiy <pavel.zbitskiy@gmail.com>
>
> It was broken by 4ce6243dc6216e35b5b691078ffa856463bfa8db,
> where TARGET_CLONE_BACKWARDS was specified instead of
> TARGET_CLONE_BACKWARDS2.
>
> Signed-off-by: Pavel Zbitskiy <pavel.zbitskiy@gmail.com>
> ---
>  linux-user/s390x/syscall.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/s390x/syscall.h b/linux-user/s390x/syscall.h
> index ea8c304..e5ce30b 100644
> --- a/linux-user/s390x/syscall.h
> +++ b/linux-user/s390x/syscall.h
> @@ -22,4 +22,4 @@ struct target_pt_regs {
>
>  #define UNAME_MACHINE "s390x"
>
> -#define TARGET_CLONE_BACKWARDS
> +#define TARGET_CLONE_BACKWARDS2

Yep, kernel config agrees:
http://lxr.free-electrons.com/source/arch/s390/Kconfig#L99

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM