From: Peter Maydell <peter.maydell@linaro.org>
To: BALATON Zoltan <balaton@eik.bme.hu>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
Nicholas Piggin <npiggin@gmail.com>,
Harsh Prateek Bora <harshpb@linux.ibm.com>
Subject: Re: [PATCH] hw/ppc/pegasos: Fix memory leak
Date: Sun, 2 Nov 2025 11:41:19 +0000 [thread overview]
Message-ID: <CAFEAcA9HMKVZt_p8uea7yTPmN0Of0cJwWXxpLfFT8bB6TvMZ6g@mail.gmail.com> (raw)
In-Reply-To: <20251101165236.76E8B5972E3@zero.eik.bme.hu>
On Sat, 1 Nov 2025 at 16:53, BALATON Zoltan <balaton@eik.bme.hu> wrote:
>
> Commit 9099b430a4 introduced an early return that caused a leak of a
> GString. Allocate it later to avoid the leak.
>
> Fixes: 9099b430a4 (hw/ppc/pegasos2: Change device tree generation)
> Resolves: Coverity CID 1642027
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
next prev parent reply other threads:[~2025-11-02 11:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-01 16:52 [PATCH] hw/ppc/pegasos: Fix memory leak BALATON Zoltan
2025-11-02 11:41 ` Peter Maydell [this message]
2025-11-03 2:21 ` Harsh Prateek Bora
2025-11-03 9:39 ` Peter Maydell
2025-11-03 9:47 ` Harsh Prateek Bora
2025-11-03 12:33 ` BALATON Zoltan
2025-11-09 12:33 ` Harsh Prateek Bora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA9HMKVZt_p8uea7yTPmN0Of0cJwWXxpLfFT8bB6TvMZ6g@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=balaton@eik.bme.hu \
--cc=harshpb@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).